Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix for failing Android build on react-native-fingerprint-scanner dependency #6131

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR fixes an unresolvable dependency during Android release.

List of changes proposed in this pull request

How to test

Run the release workflow

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 29, 2024

Warnings
⚠️ Please include a Jira ticket at the beginning of the PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against ad1c969

@CrisTofani CrisTofani changed the title [chore] Fix for failing Android build on react-native-fingerprint-scanner dependency chore: Fix for failing Android build on react-native-fingerprint-scanner dependency Aug 29, 2024
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (4f204b4) to head (ad1c969).
Report is 424 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6131      +/-   ##
==========================================
- Coverage   48.42%   47.67%   -0.75%     
==========================================
  Files        1488     1720     +232     
  Lines       31617    34760    +3143     
  Branches     7669     8363     +694     
==========================================
+ Hits        15311    16573    +1262     
- Misses      16238    18117    +1879     
- Partials       68       70       +2     

see 1176 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d62d7...ad1c969. Read the comment docs.

@CrisTofani CrisTofani merged commit 1ff3b91 into master Aug 29, 2024
13 checks passed
@CrisTofani CrisTofani deleted the chore/fingerprint branch August 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants