Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-453] Add the new static Appearance profile screen #6573

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Dec 19, 2024

Warning

At the moment the added screen is completely static, with no logic attached.

Short description

This PR adds the new Appearance screen in the Preferences page (under Settings)

List of changes proposed in this pull request

  • Add the new screen with relative routes
  • Add a teaser for the future dark mode release

Preview

Note

The new icons are visible only in the related PR

appearance-screen-last-iteration.mp4

How to test

Go to SettingsPreferencesAppearance

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter Dark mode 🌝 copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOAPPX-453

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.35%. Comparing base (ea2663f) to head (22113c0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/screens/profile/AppearancePreferenceScreen.tsx 16.66% 5 Missing ⚠️
ts/screens/profile/PreferencesScreen.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6573      +/-   ##
==========================================
- Coverage   49.36%   49.35%   -0.01%     
==========================================
  Files        1565     1566       +1     
  Lines       32230    32238       +8     
  Branches     7290     7337      +47     
==========================================
+ Hits        15910    15911       +1     
+ Misses      16282    16277       -5     
- Partials       38       50      +12     
Files with missing lines Coverage Δ
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/screens/profile/PreferencesScreen.tsx 6.45% <0.00%> (-0.45%) ⬇️
ts/screens/profile/AppearancePreferenceScreen.tsx 16.66% <16.66%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5333333...22113c0. Read the comment docs.

@dmnplb
Copy link
Contributor Author

dmnplb commented Jan 10, 2025

changes proposed by @mariateresaventura

@thisisjp To make it even simpler, I just replaced "the style of the app" with "the app". So in the end it's "Choose how to customise the app". @mariateresaventura Is it still acceptable?

@mariateresaventura
Copy link
Contributor

changes proposed by @mariateresaventura

@thisisjp To make it even simpler, I just replaced "the style of the app" with "the app". So in the end it's "Choose how to customise the app". @mariateresaventura Is it still acceptable?

@dmnplb @thisisjp I suggest to simplify in "Personalizza l'aspetto dell'app"/"Customise how the app looks"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark mode 🌝 Design System New visual language and reduction of previous UI clutter dont-merge ✋
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants