-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOBP-1094] Standardize legacy switch/radio for IDPay screen #6584
base: master
Are you sure you want to change the base?
Conversation
replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1094 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6584 +/- ##
=======================================
Coverage 49.33% 49.33%
=======================================
Files 1565 1565
Lines 32275 32270 -5
Branches 7290 7337 +47
=======================================
- Hits 15923 15921 -2
+ Misses 16313 16311 -2
+ Partials 39 38 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This pull request align legacy IDPay switch/radio components with design standards
Warning
This PR depends on #6583
List of changes proposed in this pull request
ListItemComponent
withListItemSwitch
for switch renderingListItemComponent
withRadioGroup
for radio renderingHow to test
Ensure that all legacy IDPay switch/radio are aligned with the established design requirements