Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [IOBP-1094] Standardize legacy switch/radio for IDPay screen #6584

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request align legacy IDPay switch/radio components with design standards

Warning

This PR depends on #6583

List of changes proposed in this pull request

  • Replace ListItemComponent with ListItemSwitch for switch rendering
  • Replace ListItemComponent with RadioGroup for radio rendering

How to test

Ensure that all legacy IDPay switch/radio are aligned with the established design requirements

replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 3, 2025
@LeleDallas LeleDallas self-assigned this Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1094

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (9382eeb) to head (0badea1).

Files with missing lines Patch % Lines
...pay/configuration/screens/IbanEnrollmentScreen.tsx 0.00% 6 Missing ⚠️
...boarding/screens/MultiValuePrerequisitesScreen.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6584   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files        1565     1565           
  Lines       32275    32270    -5     
  Branches     7290     7337   +47     
=======================================
- Hits        15923    15921    -2     
+ Misses      16313    16311    -2     
+ Partials       39       38    -1     
Files with missing lines Coverage Δ
...nboarding/screens/BoolValuePrerequisitesScreen.tsx 5.88% <ø> (ø)
...boarding/screens/MultiValuePrerequisitesScreen.tsx 9.52% <0.00%> (-5.87%) ⬇️
...pay/configuration/screens/IbanEnrollmentScreen.tsx 4.34% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9382eeb...0badea1. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants