-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[IOBP-1119]: Adapt IDPay custom table and list to design system components #6597
Open
LeleDallas
wants to merge
37
commits into
master
Choose a base branch
from
IOBP-1119-convert-table-and-custom-list-to-list-item-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor[IOBP-1119]: Adapt IDPay custom table and list to design system components #6597
LeleDallas
wants to merge
37
commits into
master
from
IOBP-1119-convert-table-and-custom-list-to-list-item-component
+887
−1,235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
Replace RNavScreenWithLargeHeader with IOScrollViewWithLargeHeader
replace Layout with LinearTransition
replace GradientScrollView with IOScrollView
Replace IOScrollView with IOScrollViewWithLargeHeader as it provides more props for rendering purpose
Remove `SafeAreaView`, `Scrollview` and custom floating button in favor of `OperationResultScreenContent` and `IOScrollViewWithLargeHeader`
Migrate from useHeaderSecondLevel to IOScrollViewWithLargeHeader
Remove old footer action button
…-upgrade-deprecated-components-for-idpay
…-upgrade-deprecated-components-for-idpay
… IOBP-1119-convert-table-and-custom-list-to-list-item-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Warning
This PR depends on #6586
This pull request focuses on enhancing the integration of the design system list components for IDPay screens currently utilizing custom tables and lists
List of changes proposed in this pull request
ListItem
to IDPay timeline screensListItem
to IDPay initiative screensTable
component moving its type in main fileHow to test
Ensure that all replaced components are properly aligned with design standards
##Preview
Screen.Recording.2025-01-10.at.18.31.38.mov