[SIW-1953] Mixpanel tracking of new ITWallet feature #6601

RiccardoMolinari95 · 2025-01-14T13:27:39Z

Short description

This PR add the tracking on mixpanel of some ITWallet events

Warning

Depens on #6577

List of changes proposed in this pull request

trackItwStatusWalletAttestationFailure when the wallet attestation fails.
trackItwStatusCredentialAttestationFailure when the credential attestation fails
trackItwTrustmarkRenewFailure when the generation of the QR Code for attesting the authenticity of the credential fails
trackCredentialCardModal when a credential is viewed in landscape mode
trigger the event FIMS_START by clicking the CTA towards iPatente through the trackAuthenticationStart function
added in ItwPresentationDetailsFooter const for tracking iPatente service

How to test

Verify that the newly added events are tracked correctly

…-new-itw-mixpanel-events

github-actions · 2025-01-14T13:27:51Z

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1953

codecov · 2025-01-14T14:06:18Z

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.34%. Comparing base (483cdf2) to head (51238e9).
Report is 5 commits behind head on SIW-1918-add-ipatente-cta-in-mdl-details-screen.

Files with missing lines	Patch %	Lines
ts/features/itwallet/analytics/index.ts	60.00%	4 Missing ⚠️
...ion/screens/ItwPresentationCredentialCardModal.tsx	0.00%	3 Missing ⚠️
...reens/ItwPresentationCredentialFiscalCodeModal.tsx	0.00%	3 Missing ⚠️
...dentials/saga/checkCredentialsStatusAttestation.ts	0.00%	1 Missing ⚠️
...tation/components/ItwPresentationDetailsFooter.tsx	80.00%	1 Missing ⚠️

Additional details and impacted files

@@                                 Coverage Diff                                 @@
##           SIW-1918-add-ipatente-cta-in-mdl-details-screen    #6601      +/-   ##
===================================================================================
- Coverage                                            49.37%   49.34%   -0.03%     
===================================================================================
  Files                                                 1566     1566              
  Lines                                                32247    32281      +34     
  Branches                                              7335     7334       -1     
===================================================================================
+ Hits                                                 15921    15930       +9     
- Misses                                               16276    16313      +37     
+ Partials                                                50       38      -12

Files with missing lines	Coverage Δ
...let/lifecycle/saga/checkWalletInstanceStateSaga.ts	`92.30% <100.00%> (+0.64%)`	⬆️
ts/features/itwallet/trustmark/machine/machine.ts	`80.95% <100.00%> (+2.00%)`	⬆️
...dentials/saga/checkCredentialsStatusAttestation.ts	`5.26% <0.00%> (-0.30%)`	⬇️
...tation/components/ItwPresentationDetailsFooter.tsx	`67.56% <80.00%> (+1.94%)`	⬆️
...ion/screens/ItwPresentationCredentialCardModal.tsx	`17.64% <0.00%> (-3.79%)`	⬇️
...reens/ItwPresentationCredentialFiscalCodeModal.tsx	`34.78% <0.00%> (-5.22%)`	⬇️
ts/features/itwallet/analytics/index.ts	`34.40% <60.00%> (+1.45%)`	⬆️

... and 28 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483cdf2...51238e9. Read the comment docs.

mastro993 · 2025-01-14T16:11:49Z

ts/features/itwallet/presentation/components/ItwPresentationDetailsFooter.tsx

+        trackAuthenticationStart(
+          serviceId,
+          serviceName,
+          serviceOrganizationName,
+          serviceOrganizationFiscalCode,
+          label,
+          "message_detail"
+        );


What do you think about creating a specific function for this tracking, removing the need to have const values here?
Also, I think message_detail is not correct for this specific use case. Should be something different, like "credential_detail".

mastro993 · 2025-01-14T16:14:08Z

ts/features/itwallet/trustmark/machine/machine.ts

-      failure: ({ event }) => mapEventToFailure(event)
+      failure: ({ event, context }) => {
+        const failure = mapEventToFailure(event);
+        trackItwTrustmarkRenewFailure(CREDENTIALS_MAP[context.credentialType]);


This is an assigment action, which should be pure. We should create an action specific for this tracking and call it in the entry transition of Failure state.

You're right, thanks for the suggestion. Addressed in 9318e43

…ack trustmark failure

Vangaorth · 2025-01-15T08:43:23Z

ts/features/itwallet/presentation/components/ItwPresentationDetailsFooter.tsx

+const serviceOrganizationName =
+  "Ministero delle infrastrutture e dei trasporti";
+const serviceOrganizationFiscalCode = "97532760580";
+const serviceName = "Motorizzazione Civile - Le mie patenti";


What if the service is later renamed to something else? Or the organisation? Or what if the service is recreated, with different ids? Apart from keeping track of such changes, this code will send bad data to the mixpanel boards and we will have to release a new version of the application in order to change it.

Why do not we use a CDN to store these data?

RiccardoMolinari95 added 2 commits January 14, 2025 12:28

Merge commit '483cdf290ffc9da4326410901b9973720cf9bc0d' into SIW-1953…

1995ab7

…-new-itw-mixpanel-events

chore: add mixpanel events tracking for new itw feature

a7e2058

RiccardoMolinari95 requested review from ChrisMattew, gispada, freddi301 and a team as code owners January 14, 2025 13:27

RiccardoMolinari95 self-assigned this Jan 14, 2025

RiccardoMolinari95 added 2 commits January 14, 2025 14:39

chore: prettierfix lit

f435657

chore: fix lint

aad58ec

RiccardoMolinari95 temporarily deployed to dev January 14, 2025 14:00 — with GitHub Actions Inactive

RiccardoMolinari95 changed the title ~~[SIW-1953] Tracking of new ITWallet feature~~ [SIW-1953] Mixpanel tracking of new ITWallet feature Jan 14, 2025

mastro993 reviewed Jan 14, 2025

View reviewed changes

RiccardoMolinari95 added 2 commits January 15, 2025 09:18

chore: create trackTrustmarkFailure action in trustmark machine to tr…

9318e43

…ack trustmark failure

fix: prettier

51238e9

RiccardoMolinari95 temporarily deployed to dev January 15, 2025 08:38 — with GitHub Actions Inactive

Vangaorth requested changes Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIW-1953] Mixpanel tracking of new ITWallet feature #6601

[SIW-1953] Mixpanel tracking of new ITWallet feature #6601

RiccardoMolinari95 commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

mastro993 Jan 14, 2025 •

edited

Loading

mastro993 Jan 14, 2025

RiccardoMolinari95 Jan 15, 2025

Vangaorth Jan 15, 2025

[SIW-1953] Mixpanel tracking of new ITWallet feature #6601

Are you sure you want to change the base?

[SIW-1953] Mixpanel tracking of new ITWallet feature #6601

Conversation

RiccardoMolinari95 commented Jan 14, 2025 • edited Loading

Short description

List of changes proposed in this pull request

How to test

github-actions bot commented Jan 14, 2025 • edited Loading

Jira Pull Request Link

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

mastro993 Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

mastro993 Jan 14, 2025

Choose a reason for hiding this comment

RiccardoMolinari95 Jan 15, 2025

Choose a reason for hiding this comment

Vangaorth Jan 15, 2025

Choose a reason for hiding this comment

RiccardoMolinari95 commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

mastro993 Jan 14, 2025 •

edited

Loading