Skip to content

Commit

Permalink
Fix default canary step time size to 5 minutes
Browse files Browse the repository at this point in the history
  • Loading branch information
BurnedMarshal committed Jan 13, 2025
1 parent fe3866c commit 2f023b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/_function_app_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ on:
description: Time between canary traffic increment steps
type: number
required: false
default: 30000
default: 300000
concurrency:
group: ${{ github.workflow }}-cd
cancel-in-progress: true
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:

# Validate that the fields are present
if [ -z "$nextIncrementPercentage" ] || [ -z "$afterMs" ]; then
echo "Invaliga .d output from script (missing nextIncrementPercentage or afterMs)."
echo "Invalid output from script (missing nextIncrementPercentage or afterMs)."
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletion packages/canary-deployment-monitor/src/env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const CanaryMonitorConfig = t.type({
FUNCTION_APP_NAME: t.string,
LOG_ANALITYCS_WORKSPACE_ID: t.string,
CANARY_INCREMENT_STEP: withDefault(t.string, "10").pipe(NumberFromString), // 10 percent
CANARY_NEXT_STEP_AFTER_MS: withDefault(t.string, "30000").pipe(
CANARY_NEXT_STEP_AFTER_MS: withDefault(t.string, "300000").pipe(
NumberFromString,
), // 5 minutes
});
Expand Down

0 comments on commit 2f023b5

Please sign in to comment.