Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles to Infra CD Identity to access APIM secrets #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Krusty93
Copy link
Contributor

List of Changes

Add API Management Service Contributor role to Infra CD identity using APIM resource groups as scope

Motivation and Context

Need to read subscription keys

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Krusty93 Krusty93 requested review from a team as code owners January 22, 2025 17:22
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: c693a7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Jira Pull request Link

It seems this Pull Request has no issues that refers to Jira!!!
Please check it out.

Copy link
Contributor

@giamma1295 giamma1295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati
Copy link
Contributor

@Krusty93, could you confirm if this change has been applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants