[IOPLT-807] Update Azure Tags of Core module resources

[Krusty93]

Motivation and Context

Tagging strategy have been updated

Major Changes

Update tags

Dependencies

Testing

Documentation

Other Considerations

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

📖 Terraform Plan ('src/core/prod') - success

Terraform Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.custom_roles.azurerm_role_definition.pagopa_opex_contributor will be updated in-place
  ~ resource "azurerm_role_definition" "pagopa_opex_contributor" {
      ~ assignable_scopes           = [
            "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b",
          - "/subscriptions/d7de83e0-0571-40ad-b63a-64c942385eae",
        ]
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/providers/Microsoft.Authorization/roleDefinitions/b487bfdf-3964-31c3-a18f-387cc7aec2c6|/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b"
        name                        = "PagoPA Opex Dashboards Contributor"
        # (4 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Deprecated attribute

  on ../_modules/vpn/main.tf line 27, in module "vpn":
  27:       aad_audience          = data.azuread_application.vpn_app.application_id

The attribute "application_id" is deprecated. Refer to the provider
documentation for details.

(and one more similar warning elsewhere)

Warning: Argument is deprecated

  with module.azdoa_weu.module.azdoa_snet.azurerm_subnet.this,
  on .terraform/modules/azdoa_weu.azdoa_snet/subnet/main.tf line 23, in resource "azurerm_subnet" "this":
  23:   private_endpoint_network_policies_enabled     = var.private_endpoint_network_policies_enabled

`private_endpoint_network_policies_enabled` will be removed in favour of the
property `private_endpoint_network_policies` in version 4.0 of the AzureRM
Provider

(and 14 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.