-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [EUDIW-170] Upgrade react native to 75 #168
Open
luca-soda
wants to merge
5
commits into
master
Choose a base branch
from
update-react-native-to-75
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LazyAfternoons
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please follow our convention for the PR title? There are also a few conflicts to be solved. Thanks.
luca-soda
changed the title
Update react native to 75
feat: [EUDIW-170] upgrade react native to 75
Dec 11, 2024
LazyAfternoons
changed the title
feat: [EUDIW-170] upgrade react native to 75
feat: [EUDIW-170] Upgrade react native to 75
Dec 11, 2024
LazyAfternoons
requested changes
Dec 16, 2024
Comment on lines
+5
to
9
"@pagopa/io-react-native-wallet": ["./src/index"], | ||
"@pagopa/io-react-native-jwt": [ | ||
"./node_modules/@pagopa/io-react-native-jwt/src/index.ts" | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this change? Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
This PR upgrades the project to React Native 0.75.4 from 0.72.14 to ensure compatibility with the latest features, fixes, and performance improvements provided by the framework.
Motivation and Context
This upgrade is essential to keep the project up-to-date with the latest React Native improvements
How Has This Been Tested?
Manual testing: compiled and ran Android.
I can't compile on iOS at the moment.
Checklist: