feat: PAGOPA-2379 V3 API #274

cap-ang · 2024-12-06T17:01:16Z

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

google-java-format

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/InstallmentMetadataModel.java

Lines 13 to 15 in fe1fae9

    
           @NotBlank(message = "key is required") 
        
           private String key; 
        
           private String value;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/InstallmentModel.java

Lines 7 to 13 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor; 
        
           import javax.validation.Valid; 
        
           import javax.validation.constraints.NotBlank; 
        
           import javax.validation.constraints.NotNull; 
        
           import javax.validation.constraints.Size;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/InstallmentModel.java

Line 18 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/InstallmentModel.java

Lines 23 to 65 in fe1fae9

    
           private String nav; 
        
           @NotBlank(message = "iuv is required") 
        
           private String iuv; 
        
           @NotNull(message = "amount is required") 
        
           private Long amount; 
        
           @NotBlank(message = "payment option description is required") 
        
           @Size(max = 140) // compliant to paForNode.xsd 
        
           private String description; 
        
           @NotNull(message = "due date is required") 
        
           private LocalDateTime dueDate; 
        
           @JsonProperty(access = JsonProperty.Access.READ_ONLY) 
        
           @Schema(accessMode = Schema.AccessMode.READ_ONLY) 
        
           private long fee; 
        
           @JsonProperty(access = JsonProperty.Access.READ_ONLY) 
        
           @Schema(accessMode = Schema.AccessMode.READ_ONLY) 
        
           private long notificationFee; 
        
           @JsonProperty(access = JsonProperty.Access.READ_ONLY) 
        
           @Schema(accessMode = Schema.AccessMode.READ_ONLY) 
        
           private InstallmentStatus status; 
        
           @Valid 
        
           private List<TransferModel> transfer = new ArrayList<>(); 
        
           @Valid 
        
           @Size(min=0, max=10) 
        
           @Schema(description = "it can added a maximum of 10 key-value pairs for metadata") 
        
           private List<InstallmentMetadataModel> installmentMetadata = new ArrayList<>(); 
        
           public void addTransfers(TransferModel trans) { 
        
               transfer.add(trans); 
        
           } 
        
           public void removeTransfers(TransferModel trans) { 
        
               transfer.remove(trans); 
        
           } 
        
           public void addPaymentOptionMetadata(InstallmentMetadataModel metadataModel) { 
        
               installmentMetadata.add(metadataModel); 
        
           } 
        
           public void removePaymentOptionMetadata(InstallmentMetadataModel metadataModel) { 
        
               installmentMetadata.remove(metadataModel); 
        
           }

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Lines 5 to 10 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor; 
        
           import javax.validation.Valid; 
        
           import javax.validation.constraints.NotNull; 
        
           import javax.validation.constraints.Size;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Line 15 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Lines 20 to 26 in fe1fae9

    
           @Size(max = 140) // todo use this field: is used that at the installment level 
        
           private String description; 
        
           private LocalDateTime validityDate; 
        
           private LocalDateTime retentionDate; 
        
           @Schema(description = "feature flag to enable the payment option to expire after the due date", example = "false", defaultValue = "false") 
        
           @NotNull(message = "switch to expired value is required") 
        
           private Boolean switchToExpired;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Lines 28 to 29 in fe1fae9

    
           @Valid 
        
           private DebtorModel debtor;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Lines 31 to 32 in fe1fae9

    
           @Valid 
        
           private List<InstallmentModel> installments = new ArrayList<>();

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Lines 34 to 36 in fe1fae9

    
           public void addInstallment(InstallmentModel inst) { 
        
               installments.add(inst); 
        
           }

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

Lines 38 to 40 in fe1fae9

    
           public void removeTransfers(InstallmentModel inst) { 
        
               installments.remove(inst); 
        
           }

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionModelV3.java

Lines 7 to 11 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor; 
        
           import javax.validation.Valid; 
        
           import javax.validation.constraints.*;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionModelV3.java

Line 16 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionModelV3.java

Lines 21 to 46 in fe1fae9

    
           @NotBlank(message = "iupd is required") 
        
           private String iupd; 
        
           @Schema(description = "feature flag to enable a debt position in stand-in mode", example = "true", defaultValue = "true") 
        
           private boolean payStandIn = true; 
        
           @NotBlank(message = "company name is required") 
        
           @Size(max = 140) // compliant to paForNode.xsd 
        
           private String companyName; // es. Comune di Roma 
        
           @Size(max = 140) // compliant to paForNode.xsd 
        
           private String officeName; // es. Ufficio Tributi 
        
           @JsonProperty(access = Access.READ_ONLY) 
        
           @Schema(accessMode = Schema.AccessMode.READ_ONLY) 
        
           private LocalDateTime paymentDate; 
        
           @JsonProperty(access = Access.READ_ONLY) 
        
           @Schema(accessMode = Schema.AccessMode.READ_ONLY) 
        
           private DebtPositionStatusV3 status; 
        
           @Valid 
        
           private List<@Valid PaymentOptionModelV3> paymentOption = new ArrayList<>(); 
        
           public void addPaymentOptions(PaymentOptionModelV3 paymentOpt) { 
        
               paymentOption.add(paymentOpt); 
        
           } 
        
           public void removePaymentOptions(PaymentOptionModelV3 paymentOpt) { 
        
               paymentOption.remove(paymentOpt); 
        
           }

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionsInfoV3.java

Line 3 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionsInfoV3.java

Lines 10 to 11 in fe1fae9

	import lombok.*;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionsInfoV3.java

Line 14 in fe1fae9

import java.util.List;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionsInfoV3.java

Lines 25 to 29 in fe1fae9

    
           @JsonProperty("payment_position_list") 
        
           @Schema(required = true) 
        
           @NotNull 
        
           @Valid 
        
           private List<PaymentPositionModelResponseV3> ppBaseResponseList;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionsInfoV3.java

Lines 31 to 35 in fe1fae9

    
           @JsonProperty("page_info") 
        
           @Schema(required = true) 
        
           @NotNull 
        
           @Valid 
        
           private PageInfo pageInfo;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentMetadataModelResponse.java

Line 3 in fe1fae9

import lombok.AllArgsConstructor;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentMetadataModelResponse.java

Lines 8 to 9 in fe1fae9

	import java.io.Serializable;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentMetadataModelResponse.java

Lines 15 to 16 in fe1fae9

    
           private String key; 
        
           private String value;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentModelResponse.java

Lines 5 to 7 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentModelResponse.java

Line 12 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentModelResponse.java

Lines 17 to 32 in fe1fae9

    
           private String nav; 
        
           private String iuv; 
        
           private String organizationFiscalCode; 
        
           private long amount; 
        
           private String description; 
        
           private LocalDateTime dueDate; 
        
           private LocalDateTime paymentDate; 
        
           private LocalDateTime reportingDate; 
        
           private String paymentMethod; 
        
           private String pspCompany; 
        
           private long fee; 
        
           private long notificationFee; 
        
           private String idReceipt; 
        
           private String idFlowReporting; 
        
           private InstallmentStatus status; 
        
           private LocalDateTime lastUpdatedDate;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentModelResponse.java

Line 34 in fe1fae9

    
           private List<InstallmentMetadataModelResponse> installmentMetadata = new ArrayList<>();

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/InstallmentModelResponse.java

Line 36 in fe1fae9

private List<TransferModelResponse> transfer = new ArrayList<>();

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentOptionModelResponseV3.java

Lines 4 to 6 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentOptionModelResponseV3.java

Line 11 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentOptionModelResponseV3.java

Lines 16 to 21 in fe1fae9

    
           private LocalDateTime retentionDate; 
        
           private LocalDateTime insertedDate; 
        
           private Boolean switchToExpired; 
        
           private DebtorModel debtor; 
        
           private LocalDateTime validityDate; 
        
           private List<InstallmentModelResponse> installments = new ArrayList<>();

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Lines 4 to 6 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Line 11 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Lines 16 to 24 in fe1fae9

    
           private String iupd; 
        
           private String organizationFiscalCode; 
        
           private String companyName; // es. Comune di Roma 
        
           private String officeName; // es. Ufficio Tributi 
        
           private LocalDateTime insertedDate; 
        
           private LocalDateTime publishDate; 
        
           private LocalDateTime paymentDate; 
        
           private DebtPositionStatusV3 status; 
        
           private LocalDateTime lastUpdatedDate;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Line 26 in fe1fae9

private List<PaymentOptionModelResponseV3> paymentOption = new ArrayList<>();

...t/gov/pagopa/debtposition/controller/pd/actions/api/v3/IDebtPositionActionsControllerV3.java

...ain/java/it/gov/pagopa/debtposition/controller/pd/crud/api/v3/IDebtPositionControllerV3.java

src/main/java/it/gov/pagopa/debtposition/model/enumeration/DebtPositionStatusV3.java

src/main/java/it/gov/pagopa/debtposition/model/enumeration/InstallmentStatus.java

src/test/java/it/gov/pagopa/debtposition/OpenApiGenerationTest.java

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

google-java-format

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Lines 4 to 6 in fe1fae9

    
           import lombok.Data; 
        
           import lombok.NoArgsConstructor;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Line 11 in fe1fae9

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Lines 16 to 24 in fe1fae9

    
           private String iupd; 
        
           private String organizationFiscalCode; 
        
           private String companyName; // es. Comune di Roma 
        
           private String officeName; // es. Ufficio Tributi 
        
           private LocalDateTime insertedDate; 
        
           private LocalDateTime publishDate; 
        
           private LocalDateTime paymentDate; 
        
           private DebtPositionStatusV3 status; 
        
           private LocalDateTime lastUpdatedDate;

[google-java-format] _{reported by reviewdog 🐶}

pagopa-debt-position/src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

Line 26 in fe1fae9

private List<PaymentOptionModelResponseV3> paymentOption = new ArrayList<>();

src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentPositionsInfoV3.java

src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentOptionModelResponseV3.java

src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentPositionModelResponseV3.java

src/main/java/it/gov/pagopa/debtposition/config/SwaggerConfig.java

* feat: Add v3 API input mapper [PAGOPA-2480] - Mapping from v3 model to entity has been created * feat: Add v3 API output mapper [PAGOPA-2480] - Mapping from entity to v3 response model has been created * feat: Update v3 Update, Publish [PAGOPA-2480] - Update v3 Update CRUD - Update v3 Publish Action - Create IPaymentPositionModel interface - Fix v1 with UNDEFINED_DEBTOR default values * refactoring: Add Converter and extract class [PAGOPA-2480] - Converter PaymentPosition Entity to Model V3 has been added - In UtilityMapper class have been added common methods to map common PaymentPosition objects * refactoring: Extract methods [PAGOPA-2480] * test: Add JUnit [PAGOPA-2480] - Add DebtPositionControllerV3Test * test: Add JUnit [PAGOPA-2480] - Fix ErrorHandler - Add Create JUnit * test: Add JUnit DebtPositionControllerV3Test [PAGOPA-2480] - Add CRUD test cases for DebtPositionControllerV3Test * test: Fix JUnit test [PAGOPA-2480] * refactoring: Reformat [PAGOPA-2480] * refactoring: Resolve sonar issue [PAGOPA-2480] * Fix [PAGOPA-2480] * test: Add JUnit [PAGOPA-2480] - Add JUnit test cases GET debt-position to improve coverage on ConverterV3PPEntityToModelResponse * test: Refactoring JUnit [PAGOPA-2480] - Extract method * feat: Update GetByNAV response and refactoring [PAGOPA-2480] - Update GetByNAV: Add new condition on debtor fields - Extract UNDEFINED_DEBTOR variable in utility - Check for status coherence before set to PaymentPositionModelV3 response instance * Bump to version 0.11.74-1-PAGOPA-2480 * fix: Update Model-Entity converter [PAGOPA-2480] - The case (Opzione Unica + Opzione Rateale) has been included * Bump to version 0.11.74-2-PAGOPA-2480 * Bump to version 0.11.74-3-PAGOPA-2480 * fix: Update Response Converter [PAGOPA-2480] - Improperly created outputs: did not map correctly to the entity (caused by replace with setPaymentOption) * Bump to version 0.11.74-4-PAGOPA-2480 * config(HELM): Decrease probe initial delay [PAGOPA-2480] * Bump to version 0.11.74-5-PAGOPA-2480 * config(HELM): Increase probe initial delay [PAGOPA-2480] * test(JUnit): Add metadata in test cases [PAGOPA-2480] * chore: Adjust v3 validation [PAGOPA-2480] * Bump to version 0.11.74-6-PAGOPA-2480 * Bump to version 0.11.75-1-PAGOPA-2480 * chore: Adjust input validation [PAGOPA-2480] * chore: Update Swagger config [PAGOPA-2480] * Bump to version 0.11.75-2-PAGOPA-2480 * chore: Enhance Null Safety [PAGOPA-2480] * Bump to version 0.11.75-3-PAGOPA-2480 * refactoring: Resolve todo [PAGOPA-2480] - Update debtor type variable * Bump to version 0.11.75-4-PAGOPA-2480 --------- Co-authored-by: pagopa-github-bot <[email protected]>

src/main/java/it/gov/pagopa/debtposition/config/SwaggerConfig.java

src/main/java/it/gov/pagopa/debtposition/controller/BaseController.java

src/main/java/it/gov/pagopa/debtposition/model/IPaymentPositionModel.java

src/main/java/it/gov/pagopa/debtposition/model/v3/PaymentOptionModelV3.java

src/main/java/it/gov/pagopa/debtposition/model/v3/response/PaymentOptionModelResponseV3.java

src/main/java/it/gov/pagopa/debtposition/service/pd/crud/PaymentPositionCRUDService.java

src/main/java/it/gov/pagopa/debtposition/controller/BaseController.java

src/main/java/it/gov/pagopa/debtposition/exception/AppError.java

src/main/java/it/gov/pagopa/debtposition/service/pd/crud/PaymentPositionCRUDService.java

github-actions · 2025-01-15T14:05:50Z

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

src/main/java/it/gov/pagopa/debtposition/controller/payments/api/impl/PaymentsController.java

...main/java/it/gov/pagopa/debtposition/controller/pd/crud/api/v3/DebtPositionControllerV3.java

[PAGOPA-2480]

src/main/java/it/gov/pagopa/debtposition/controller/payments/api/impl/PaymentsController.java

...main/java/it/gov/pagopa/debtposition/controller/pd/crud/api/v3/DebtPositionControllerV3.java

[PAGOPA-2379]

[PAGOPA-2379] - Remove field injection java:S6813

...a/it/gov/pagopa/debtposition/controller/pd/actions/api/v1/DebtPositionActionsController.java

src/main/java/it/gov/pagopa/debtposition/controller/pd/crud/api/v1/DebtPositionController.java

[PAGOPA-2379]

...a/it/gov/pagopa/debtposition/controller/pd/actions/api/v1/DebtPositionActionsController.java

src/main/java/it/gov/pagopa/debtposition/controller/pd/crud/api/v1/DebtPositionController.java

github-actions · 2025-01-15T15:49:19Z

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

sonarqubecloud · 2025-01-15T15:51:43Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cap-ang self-assigned this Dec 6, 2024

github-actions bot added the size/large label Dec 6, 2024

cap-ang added documentation Improvements or additions to documentation ignore-for-release Ignore pull request from the release labels Dec 12, 2024

cap-ang marked this pull request as ready for review December 12, 2024 16:27

cap-ang requested a review from a team as a code owner December 12, 2024 16:27

cap-ang added 7 commits December 17, 2024 14:34

[PAGOPA-2379] feat: GPD options API

3f2f63a

[PAGOPA-2379] doc: Update README.md

d4c1265

[PAGOPA-2379] fix

e6a80e0

[PAGOPA-2379] fix(swagger)

2dd3fd6

[PAGOPA-2379] refactoring(swagger)

33bb0a5

[PAGOPA-2379] refactoring(swagger)

597f286

[PAGOPA-2379] fix(swagger)

70b090a

cap-ang force-pushed the PAGOPA-2379 branch from cd77cee to 70b090a Compare December 17, 2024 13:34

Merge branch 'main' into PAGOPA-2379

fe1fae9

github-actions bot reviewed Dec 19, 2024

View reviewed changes

src/test/java/it/gov/pagopa/debtposition/OpenApiGenerationTest.java Outdated Show resolved Hide resolved

cap-ang changed the title ~~[PAGOPA-2379] feat: GPD options API~~ [PAGOPA-2379] feat: V3 API definition Dec 20, 2024

github-actions bot reviewed Dec 20, 2024

View reviewed changes

Merge branch 'main' into PAGOPA-2379

6e828d8

github-actions bot reviewed Jan 8, 2025

View reviewed changes

Merge branch 'main' into PAGOPA-2379

5b8cb6a

pasqualespica changed the title ~~[PAGOPA-2379] feat: V3 API definition~~ feat : [PAGOPA-2379] V3 API definition Jan 14, 2025

pasqualespica requested changes Jan 14, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/config/SwaggerConfig.java Outdated Show resolved Hide resolved

cap-ang changed the title ~~feat : [PAGOPA-2379] V3 API definition~~ feat: PAGOPA-2379 V3 API definition Jan 14, 2025

pasqualespica mentioned this pull request Jan 14, 2025

feat: PAGOPA-2480 V3 API development #285

Merged

5 tasks

cap-ang changed the title ~~feat: PAGOPA-2379 V3 API definition~~ feat: PAGOPA-2379 V3 API Jan 15, 2025

github-actions bot reviewed Jan 15, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/controller/BaseController.java Show resolved Hide resolved

github-actions bot reviewed Jan 15, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/controller/BaseController.java Show resolved Hide resolved

github-actions bot reviewed Jan 15, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/exception/AppError.java Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 15, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/exception/AppError.java Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 15, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/service/pd/crud/PaymentPositionCRUDService.java Show resolved Hide resolved

github-actions bot reviewed Jan 15, 2025

View reviewed changes

src/main/java/it/gov/pagopa/debtposition/service/pd/crud/PaymentPositionCRUDService.java Show resolved Hide resolved

Bump to version 0.11.75-5-PAGOPA-2379

81a380f

cap-ang added the patch label Jan 15, 2025

cap-ang added dev uat and removed ignore-for-release Ignore pull request from the release documentation Improvements or additions to documentation labels Jan 15, 2025

github-advanced-security bot found potential problems Jan 15, 2025

View reviewed changes

cap-ang added 2 commits January 15, 2025 15:36

refactoring: Update fullName constraint

e467a88

[PAGOPA-2480]

refactoring(logging): Sanitize log

940f878

[PAGOPA-2480]

github-advanced-security bot found potential problems Jan 15, 2025

View reviewed changes

cap-ang added 2 commits January 15, 2025 16:19

refactoring: Fix some issue

6d490f4

[PAGOPA-2379]

refactoring: Improve quality

01b1ba9

[PAGOPA-2379] - Remove field injection java:S6813

github-advanced-security bot found potential problems Jan 15, 2025

View reviewed changes

refactoring(logging): Sanitize log

b1bed22

[PAGOPA-2379]

github-advanced-security bot found potential problems Jan 15, 2025

View reviewed changes

cap-ang requested a review from pasqualespica January 15, 2025 15:46

Bump to version 0.11.75-6-PAGOPA-2379

ea6b6d3

cap-ang had a problem deploying to uat January 15, 2025 15:59 — with GitHub Actions Failure

cap-ang deployed to uat January 15, 2025 16:00 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: PAGOPA-2379 V3 API #274

feat: PAGOPA-2379 V3 API #274

cap-ang commented Dec 6, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

sonarqubecloud bot commented Jan 15, 2025

	@NotBlank(message = "key is required")
	private String key;
	private String value;

	import lombok.Data;
	import lombok.NoArgsConstructor;

	import javax.validation.Valid;
	import javax.validation.constraints.NotBlank;
	import javax.validation.constraints.NotNull;
	import javax.validation.constraints.Size;

	private String nav;
	@NotBlank(message = "iuv is required")
	private String iuv;
	@NotNull(message = "amount is required")
	private Long amount;
	@NotBlank(message = "payment option description is required")
	@Size(max = 140) // compliant to paForNode.xsd
	private String description;
	@NotNull(message = "due date is required")
	private LocalDateTime dueDate;
	@JsonProperty(access = JsonProperty.Access.READ_ONLY)
	@Schema(accessMode = Schema.AccessMode.READ_ONLY)
	private long fee;
	@JsonProperty(access = JsonProperty.Access.READ_ONLY)
	@Schema(accessMode = Schema.AccessMode.READ_ONLY)
	private long notificationFee;
	@JsonProperty(access = JsonProperty.Access.READ_ONLY)
	@Schema(accessMode = Schema.AccessMode.READ_ONLY)
	private InstallmentStatus status;

	@Valid
	private List<TransferModel> transfer = new ArrayList<>();

	@Valid
	@Size(min=0, max=10)
	@Schema(description = "it can added a maximum of 10 key-value pairs for metadata")
	private List<InstallmentMetadataModel> installmentMetadata = new ArrayList<>();

	public void addTransfers(TransferModel trans) {
	transfer.add(trans);
	}

	public void removeTransfers(TransferModel trans) {
	transfer.remove(trans);
	}

	public void addPaymentOptionMetadata(InstallmentMetadataModel metadataModel) {
	installmentMetadata.add(metadataModel);
	}

	public void removePaymentOptionMetadata(InstallmentMetadataModel metadataModel) {
	installmentMetadata.remove(metadataModel);
	}

	@Size(max = 140) // todo use this field: is used that at the installment level
	private String description;
	private LocalDateTime validityDate;
	private LocalDateTime retentionDate;
	@Schema(description = "feature flag to enable the payment option to expire after the due date", example = "false", defaultValue = "false")
	@NotNull(message = "switch to expired value is required")
	private Boolean switchToExpired;

	@Valid
	private List<InstallmentModel> installments = new ArrayList<>();

	public void addInstallment(InstallmentModel inst) {
	installments.add(inst);
	}

	public void removeTransfers(InstallmentModel inst) {
	installments.remove(inst);
	}

	@NotBlank(message = "iupd is required")
	private String iupd;
	@Schema(description = "feature flag to enable a debt position in stand-in mode", example = "true", defaultValue = "true")
	private boolean payStandIn = true;
	@NotBlank(message = "company name is required")
	@Size(max = 140) // compliant to paForNode.xsd
	private String companyName; // es. Comune di Roma
	@Size(max = 140) // compliant to paForNode.xsd
	private String officeName; // es. Ufficio Tributi
	@JsonProperty(access = Access.READ_ONLY)
	@Schema(accessMode = Schema.AccessMode.READ_ONLY)
	private LocalDateTime paymentDate;
	@JsonProperty(access = Access.READ_ONLY)
	@Schema(accessMode = Schema.AccessMode.READ_ONLY)
	private DebtPositionStatusV3 status;

	@Valid
	private List<@Valid PaymentOptionModelV3> paymentOption = new ArrayList<>();

	public void addPaymentOptions(PaymentOptionModelV3 paymentOpt) {
	paymentOption.add(paymentOpt);
	}

	public void removePaymentOptions(PaymentOptionModelV3 paymentOpt) {
	paymentOption.remove(paymentOpt);
	}

	@JsonProperty("payment_position_list")
	@Schema(required = true)
	@NotNull
	@Valid
	private List<PaymentPositionModelResponseV3> ppBaseResponseList;

	@JsonProperty("page_info")
	@Schema(required = true)
	@NotNull
	@Valid
	private PageInfo pageInfo;

	private String nav;
	private String iuv;
	private String organizationFiscalCode;
	private long amount;
	private String description;
	private LocalDateTime dueDate;
	private LocalDateTime paymentDate;
	private LocalDateTime reportingDate;
	private String paymentMethod;
	private String pspCompany;
	private long fee;
	private long notificationFee;
	private String idReceipt;
	private String idFlowReporting;
	private InstallmentStatus status;
	private LocalDateTime lastUpdatedDate;

	private LocalDateTime retentionDate;
	private LocalDateTime insertedDate;
	private Boolean switchToExpired;
	private DebtorModel debtor;
	private LocalDateTime validityDate;
	private List<InstallmentModelResponse> installments = new ArrayList<>();

feat: PAGOPA-2379 V3 API #274

Are you sure you want to change the base?

feat: PAGOPA-2379 V3 API #274

Conversation

cap-ang commented Dec 6, 2024 • edited Loading

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

sonarqubecloud bot commented Jan 15, 2025

Quality Gate passed

cap-ang commented Dec 6, 2024 •

edited

Loading