Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PagoPA-2483 V3 DB debtor fields 2️⃣ ㏈ #278

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: PagoPA-2483 V3 DB debtor fields 2️⃣ ㏈ #278

wants to merge 19 commits into from
+144 −0

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented Dec 17, 2024 •
edited
Loading

Depends on: PagoPA-2427

List of Changes

  • added script for creating and populating new fields

Motivation and Context

  • new business rules for GPD V3 release

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli marked this pull request as ready for review December 17, 2024 14:57
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner December 17, 2024 14:57
cap-ang
cap-ang requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it was tested?
We need to get some performance and timing insight on data migration before merge it

src/main/resources/db/migration/V022__ALTER_PO_DEBTOR_FIELDS.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/V022__ALTER_PO_DEBTOR_FIELDS.sql Outdated
DECLARE
batch_size INT := 10000; -- Batch size
rows_updated INT;
BEGIN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cycle is all in one transaction, what is the acquired lock?

Copy link
Collaborator Author

@alessio-acitelli alessio-acitelli Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's a single transaction so the lock on the table is held until the end (even if I do updates by block size). I correct.

@alessio-acitelli
Copy link
Collaborator Author

How it was tested? We need to get some performance and timing insight on data migration before merge it

I tested in dev by manually launching the script. It takes a few ms.

We can also test UAT by cleaning everything up (as I did in DEV) so that it can then be re-executed via flyway

@alessio-acitelli alessio-acitelli added enhancement New feature or request gpd labels Dec 19, 2024
@cap-ang cap-ang mentioned this pull request Jan 9, 2025
Open
5 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pasqualespica pasqualespica changed the title feat: [PagoPA-2483] - V3 DB debtor fields feat: [PagoPA-2483] - V3 DB debtor fields 2️⃣ ㏈ Jan 14, 2025
@cap-ang cap-ang changed the title feat: [PagoPA-2483] - V3 DB debtor fields 2️⃣ ㏈ feat: PagoPA-2483 V3 DB debtor fields 2️⃣ ㏈ Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

@svariant svariant mentioned this pull request Jan 15, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

@cap-ang cap-ang Awaiting requested review from cap-ang

Requested changes must be addressed to merge this pull request.

Assignees

@alessio-acitelli alessio-acitelli

Labels
dev enhancement New feature or request gpd size/small uat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-acitelli @pasqualespica @cap-ang @pagopa-github-bot