Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix vulnerability Zip Slip #22

Merged
merged 2 commits into from
Apr 4, 2024
Merged

chore: fix vulnerability Zip Slip #22

merged 2 commits into from
Apr 4, 2024

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Apr 4, 2024

List of Changes

Fix Zip Slip and Local information disclosure in a temporary directory

more info:
https://github.com/pagopa/pagopa-gpd-upload/security/code-scanning/72
https://github.com/pagopa/pagopa-gpd-upload/security/code-scanning/73
OWASP: Path Traversal
OWASP: Insecure Temporary File

Motivation and Context

Code scanning result

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Apr 4, 2024
@cap-ang cap-ang requested a review from a team as a code owner April 4, 2024 13:49
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@cap-ang cap-ang merged commit d1605fa into main Apr 4, 2024
12 of 16 checks passed
@cap-ang cap-ang deleted the fix-vulnerability branch April 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant