Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test scenarios [PAGOPA-1630] #23

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Apr 5, 2024

List of Changes

New integration test scenarios:

  • CREATE debt-position by file upload
  • UPDATE debt-position by file upload
  • DELETE debt-position by file upload
  • CRUD concatenation by file upload
  • Exceed input constraints in zip uploading

Motivation and Context

  • Integration test scenarios definition

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Apr 5, 2024
@cap-ang cap-ang requested a review from a team as a code owner April 5, 2024 16:19
Scenario: Create, Update and Delete same Debt Position by file upload OK
// todo

Scenario: N x Create same Debt Position by file upload OK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N x stands for ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N creation by file upload: i.e. N files containing debt positions are being created and the files are submitted via POST N times
it is not very clear I will write it better

Then check statusCode is 202
And check location header regex ^brokers/(.+)/organizations/(.+)/debtpositions/file/(.+)/status$

Scenario: Create Debt Position by file upload KO: invalid zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid zip == ???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a zip containing more than 1 file or a file not in JSON format is invalid. Could I split these two cases, making the cases explicit?

Background:
Given GPD-Upload running

Scenario: Create Debt Position by file upload KO: file size > limit size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add limit size (xxxMb)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The effective size, greater than the limit, is already in the scenario, one day it could be GB, I prefer maintain scenario description more generic whether you agree

Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cap-ang cap-ang requested a review from pasqualespica April 8, 2024 13:46
@cap-ang cap-ang merged commit ed96f97 into main Apr 8, 2024
11 of 13 checks passed
@cap-ang cap-ang deleted the PAGOPA-1630-test-scenarios-definition branch April 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants