Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOD-934] fix: add missing fields in various entities #10

Merged
merged 6 commits into from
May 28, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented May 28, 2024

This PR contains several changes made on various entities in order to add other fields, not correctly set in previous developments. The fields to be added in the entities refers to the following table columns:

  • CANALI_NODO.FLAG_STANDIN
  • CDI_DETAIL.CANALE_APP
  • CDI_MASTER.URL_INFORMATIVA_PSP
  • CDI_MASTER.URL_CONVENZIONI_PSP
  • IBAN.RAGIONE_SOCIALE
  • INFORMATIVE_PA_MASTER.FK_ICA_BINARY_FILE
  • PA.CBILL
  • STAZIONI.PROTOCOLLO_AVV
  • STAZIONI.ID_AVV
  • STAZIONI.PORTA_AVV
  • STAZIONI.SERVIZIO_AVV
  • STAZIONI.TIMEOUT
  • STAZIONI.FLAG_STANDIN

List of Changes

  • Add several new fields in various entities, previously missed

Motivation and Context

These changes are required because the migration does not set correctly all the column values in all the tables.

How Has This Been Tested?

  • Tested in DEV environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri added the bug Something isn't working label May 28, 2024
@andrea-deri andrea-deri self-assigned this May 28, 2024
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@github-actions github-actions bot added the patch label May 28, 2024
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@andrea-deri andrea-deri removed the bug Something isn't working label May 28, 2024
Copy link
Contributor

@aomegax aomegax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

This pull request does not contain a valid label. Please add one of the following labels: [breaking-change, new-release, ignore-for-release]

Copy link

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.7% Coverage on New Code (required ≥ 80%)
13.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@aomegax aomegax merged commit f3208f6 into main May 28, 2024
8 of 12 checks passed
@aomegax aomegax deleted the NOD-934-add-missing-fields branch May 28, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants