Replace SystemConverter with SystemUpgrader #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose this type as the return type for HostAccessors.getDefault() so that clients don't have to handle IOException when opening the default system.
| } | ||
|
|
||
| @Test | ||
| public void upgradetLocalExecutionSystem() throws IOException { |
Remove close() implementation from BaseFileSystem because it was not flexible enough for real use cases (see also #24). Refactor SSH system creation to better support HostControlSystems. Essentially, constructing any system also creates its pair, but this is relatively lightweight because connections are shared. Fixes #12.
bluekeyes
force-pushed
the
fix/system-converter
branch
from
361e1fd to
7f0bed8
Compare
bluekeyes
added a commit
that referenced
this pull request
Jul 8, 2015
Replace SystemConverter with SystemUpgrader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
close()implementation fromBaseFileSystembecause it was not flexible enough for real use cases (see also #24).Refactor SSH system creation to better support
HostControlSystems. Essentially, constructing any system also creates its pair, but this is relatively lightweight because connections are shared.Fixes #12.