-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support getting metadata and contents for a Media reference property #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far on quick skim, can we also add an E2E test hitting an actual stack to make sure things are working?
@@ -19,14 +19,8 @@ import type { | |||
TimeSeriesProperty, | |||
TimeSeriesQuery, | |||
} from "@osdk/api"; | |||
import { TimeseriesDurationMapping } from "@osdk/api"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just deleting unused stuff here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup.
…edia-read-support
…edia-read-support
await this.#client.ontologyRid, | ||
...this.#triplet, | ||
{ | ||
preview: true, // TODO: Can turn this back off when backend is no longer in beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssanjay1 - setting preview=true
by default here instead of passing this on to the user (not sure it makes sense for user to know about this). Let me know if that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup makes sense
This can maybe be a FLUP, but do we want to expose any of this information that comes over the wire? Like for actions that accept a media reference, I'd imagine they'd need some combination of these rids right? |
Yup, planning to do this in the follow-up PR that handles the upload workflow. |
In fact, actions should accept that entire json blob (a media reference) as is. |
Late approval on my end as well- excited to see the upload pr! Glad we were able to have an external contribution 😄 |
Adds support to get contents and metadata for a media reference property.
Introduces
Media
type withgetMetadata()
andgetContent()
methods and necessary conversion methods from wire2SDK and tests.