Correct widget template package dependency versions #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosscourt
force-pushed
the
rc/fix-widget-template-deps-v2
branch
from
b137f74 to
5bd5b00
Compare
changeset update lock update in-repo generated package update lock
rosscourt
force-pushed
the
rc/fix-widget-template-deps-v2
branch
from
d7186cb to
6be1cf0
Compare
update locks
rosscourt
commented
Dec 19, 2024
| // Use locally generated SDK in the monorepo | ||
| /"@osdk\/widget.vite-plugin.unstable": "\^.*?"/, | ||
| `"@osdk/widget.vite-plugin.unstable": "workspace:*"`, | ||
| ) |
There was a problem hiding this comment.
@ssanjay1 I needed to introduce these replacements for the in-repo generator checks to pass
ssanjay1
approved these changes
Dec 19, 2024
ericanderson
added a commit
that referenced
this pull request
Jan 13, 2025
* origin/main: Add typed lint checks and fix promise related things (#1081) Version Packages (beta) (#1090) Export hydrateObjectSetFromRid from internal (#1087) Fetch by RID experimental (#1088) Creates new internal export for helper methods we want to hide (#1084) Add's more descriptive error messages for 429 errors and other errors with no body (#1082) Update react template per discussion (#1077) OSDK client internal property is hidden from output .d.ts (#1079) Revert `api:x-read/write` back to `api:read/write-x` (#1076) Move from "views" naming to "widgets" (#1075) Fixes attachment uploads in Browser context (#1064) Use foundry-config-json in widget-manifest-vite-plugin (#1055) Version Packages (beta) (#1072) Ignore unknown types (#1067) Correct widget template package dependency versions (#1068) Make interface type status configurable (#1069) Fix onOutOfDate handler from firing twice (#1071) Rename @osdk/widget-manifest-vite-plugin to @osdk/widget.vite-plugin.unstable (#1065) Fixing main (#1066) Add structs read support (#1047) Handle Vite plugin injections in Custom Widget Vite plugin (#1063) Version Packages (beta) (#1060) Fix unused import (#1061) Revive eslint-plugin-unused-imports (#1057) Fix URL for getBulkLinks (#1058) Split foundry-config-json package (#1054) Add package.json auto version strategy (#1052) Remove crypto from OSDK (#1051) Support site snapshot upload (#1049) Try catch subscription handlers (#1019) Experiment with no proxy for objects (#1031) Bump unstable widget packages to v1 to avoid undesired v0.x version behavior (#1050) WeakRef the as()'d objects (#1043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies are currently being copied into the template from the
package.json, resulting in invalidworkspaceversions in the end user's project. The convention used in all other templates is for these in-repo packages to be declared in the handlebars file instead. E.g:osdk-ts/packages/create-app.template.react.beta/templates/package.json.hbs
Lines 14 to 19 in 5f75268
I'm targeting #1065 because then I can also pick up a
^1version of the Vite plugin and won't need to further bump template versions to pick up fixes for that package.