Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add missing parameters to offsets classes: BQuarterBegin, BQuarterEnd, QuarterBegin, QuarterEnd #53378

Conversation

natmokval
Copy link
Contributor

xref #52431.
Updated documentation for offsets classes. Added missing parameters and See Also section to BQuarterBegin, BQuarterEnd, QuarterBegin, QuarterEnd.

@natmokval natmokval marked this pull request as ready for review May 25, 2023 12:28
@mroeschke mroeschke requested a review from MarcoGorelli May 25, 2023 16:32
@mroeschke mroeschke added Docs Frequency DateOffsets labels May 25, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone May 25, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - generally looks good, just got a question about n

Parameters
----------
n : int, default 1
The number of years represented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this years or quarters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @MarcoGorelli , you are right. n represents quarters, my mistake. I''l correct this.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval !

@MarcoGorelli MarcoGorelli merged commit 3863a48 into pandas-dev:main May 26, 2023
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 27, 2023
…erEnd, QuarterBegin, QuarterEnd (pandas-dev#53378)

* DOC: add missing parameters to offsets classes: BQuarterBegin, BQuarterEnd, QuarterBegin, QuarterEnd

* correct the description of the parameter n
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Jun 5, 2023
…erEnd, QuarterBegin, QuarterEnd (pandas-dev#53378)

* DOC: add missing parameters to offsets classes: BQuarterBegin, BQuarterEnd, QuarterBegin, QuarterEnd

* correct the description of the parameter n
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…erEnd, QuarterBegin, QuarterEnd (pandas-dev#53378)

* DOC: add missing parameters to offsets classes: BQuarterBegin, BQuarterEnd, QuarterBegin, QuarterEnd

* correct the description of the parameter n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants