Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add missing parameters to offsets classes: Second, Minute, Hour and Day #54427

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

dullibri
Copy link
Contributor

@dullibri dullibri commented Aug 5, 2023

@dullibri dullibri requested a review from MarcoGorelli as a code owner August 5, 2023 13:09
You can use the parameter ``n`` to represent a shift of n days.
>>> from pandas.tseries.offsets import Day
>>> ts = pd.Timestamp(2022, 12, 9, 15)
>>> ts.strftime('%a %d %b %Y %H:%M')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the examples, can you not use strftime? Just show the result of the repr

@mroeschke mroeschke added Docs Frequency DateOffsets labels Aug 7, 2023
@MarcoGorelli
Copy link
Member

/preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

No preview found for PR #54427. Did the docs build complete?

Comment on lines 1106 to 1108
You can use the parameter ``n`` to represent a shift of n days.
>>> from pandas.tseries.offsets import Day
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this'll render, you need a blank line before the example

@dullibri dullibri force-pushed the offsets_docs_h_s_d branch from 2249b4b to c881fdc Compare August 8, 2023 18:15
dullibri added a commit to dullibri/pandas that referenced this pull request Aug 8, 2023
@dullibri dullibri force-pushed the offsets_docs_h_s_d branch from 36785a1 to 9970fb4 Compare August 8, 2023 18:27
@dullibri dullibri force-pushed the offsets_docs_h_s_d branch from 9970fb4 to 4bdfb6b Compare August 8, 2023 18:27
@mroeschke mroeschke added this to the 2.1 milestone Aug 9, 2023
@mroeschke mroeschke merged commit 3efebd4 into pandas-dev:main Aug 9, 2023
@mroeschke
Copy link
Member

Thanks @dullibri

@dullibri dullibri deleted the offsets_docs_h_s_d branch August 9, 2023 16:30
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
…and Day (pandas-dev#54427)

* DOC: add missing parameters to offsets classes: Second, Hour and Day

* DOC: offsets removed trailing white spaces from Second, Min
ute, Hour, Day

* DOC: updated offset methods sec, min, h,d (pandas-dev#54427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants