Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of string changes for 2.3 release - part 2 #60013

Merged

Conversation

jorisvandenbossche
Copy link
Member

Follow-up on #59513, with a second set of backports

jorisvandenbossche and others added 30 commits October 10, 2024 09:08
* REF: avoid copy in StringArray factorize

* mypy fixup

* un-xfail
* DOC: Add whatsnew for 2.3.0

* fix duplicate label
* BUG (string): str.replace with negative n

* update GH ref
* TST (string) fix xfailed groupby tests (3)

* TST: non-pyarrow build
…v#59678)

* TST (string dtype): fix and clean up arrow roundtrip tests

* fix using_infer_string
* TST (string): more targeted xfails in test_string.py

* Fix no-pyarrow test

* Update pandas/tests/extension/test_string.py

Co-authored-by: Matthew Roeschke <[email protected]>

* Update pandas/tests/extension/test_string.py

Co-authored-by: Matthew Roeschke <[email protected]>

---------

Co-authored-by: Matthew Roeschke <[email protected]>
* REF: de-duplicate _str_contains

* pyright ignore
* String dtype: implement _get_common_dtype

* add specific tests

* try fix typing

* try fix typing

* suppress typing error

* support numpy 2.0 string

* fix typo
…ring_array (pandas-dev#59756)

* BUG (string dtype): fix inplace mutation with copy=False in ensure_string_array

* update
…ndas-dev#59768)

* BUG/API (string dtype): return float dtype for series[str].rank()

* update frame tests

* add whatsnew

* correct whatsnew note
…ev#59759)

* String dtype: fix isin() values handling for python storage

* address feedback
…ngine (pandas-dev#59810)

String dtype: allow string dtype in query/eval with default mumexpr engine
* String dtype: map builtin str alias to StringDtype

* fix tests

* fix datetimelike astype and more tests

* remove xfails

* try fix typing

* fix copy_view tests

* fix remaining tests with infer_string enabled

* ignore typing issue for now

* move to common.py

* simplify Categorical._str_get_dummies

* small cleanup

* fix ensure_string_array to not modify extension arrays inplace

* fix ensure_string_array once more + fix is_extension_array_dtype for str

* still xfail TestArrowArray::test_astype_str when not using infer_string

* ensure maybe_convert_objects copies object dtype input array when inferring StringDtype

* update test_1d_object_array_does_not_copy test

* update constructor copy test + do not copy in maybe_convert_objects?

* skip str.get_dummies test for now

* use pandas_dtype() instead of registry.find

* fix corner cases for calling pandas_dtype

* add TODO comment in ensure_string_array
…andas-dev#59854)

* String dtype: allow string dtype for non-raw apply with numba engine

* remove xfails

* clean-up
@jorisvandenbossche jorisvandenbossche added Build Library building on various platforms Strings String extension data type and string data labels Oct 10, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Oct 10, 2024
@jorisvandenbossche
Copy link
Member Author

Already green!
(except for a time out of pre-commit.co, but I suppose that is unrelated)

@jorisvandenbossche jorisvandenbossche merged commit 60b1b7b into pandas-dev:2.3.x Oct 10, 2024
113 of 114 checks passed
@jorisvandenbossche jorisvandenbossche deleted the 2.3.0-backports-2 branch October 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants