Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #833 #835

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix #833 #835

merged 3 commits into from
Nov 2, 2023

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Nov 2, 2023

Description

Closes #833

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #835 (1f491d8) into main (dafd1f3) will decrease coverage by 2.08%.
Report is 75 commits behind head on main.
The diff coverage is 90.68%.

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   93.80%   91.73%   -2.08%     
==========================================
  Files          59       59              
  Lines        6235     6246      +11     
==========================================
- Hits         5849     5730     -119     
- Misses        386      516     +130     
Files Coverage Δ
climpred/__init__.py 100.00% <100.00%> (ø)
climpred/conftest.py 96.18% <100.00%> (-1.80%) ⬇️
climpred/graphics.py 83.81% <100.00%> (-12.17%) ⬇️
climpred/horizon.py 96.55% <ø> (ø)
climpred/logging.py 90.90% <100.00%> (-9.10%) ⬇️
climpred/metrics.py 91.82% <100.00%> (+0.09%) ⬆️
climpred/options.py 81.48% <ø> (ø)
climpred/prediction.py 91.75% <100.00%> (-1.30%) ⬇️
climpred/reference.py 96.90% <100.00%> (-1.53%) ⬇️
climpred/stats.py 84.88% <100.00%> (+1.35%) ⬆️
... and 32 more

... and 1 file with indirect coverage changes

@aaronspring aaronspring changed the title More in test_bias_removal.py Fix #833 Nov 2, 2023
@aaronspring aaronspring merged commit bc692e2 into main Nov 2, 2023
23 checks passed
@Zeitsperre Zeitsperre deleted the aaronspring-patch-1 branch January 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xclim.DetrendedQuantileMapping with train_test_split="unfair" failing
1 participant