style: warn and fix more clippy lints

Cargo.toml

@@ -52,3 +52,5 @@ pedantic = "warn"
 perf = "warn"
 style = "warn"
 suspicious = "warn"
+unused_trait_names = "warn"
+ref_patterns = "warn"

benches/actions.rs

@@ -2,7 +2,7 @@ use std::time::Duration;
 
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 
-use rusty_s3::{Bucket, Credentials, S3Action, UrlStyle};
+use rusty_s3::{Bucket, Credentials, S3Action as _, UrlStyle};
 
 fn criterion_benchmark(c: &mut Criterion) {
     c.bench_function("Authenticated GetObject", |b| {

examples/create_bucket.rs

@@ -2,7 +2,7 @@ use std::error::Error as StdError;
 use std::time::Duration;
 
 use reqwest::Client;
-use rusty_s3::actions::{CreateBucket, S3Action};
+use rusty_s3::actions::{CreateBucket, S3Action as _};
 use rusty_s3::{Bucket, Credentials, UrlStyle};
 
 const ONE_HOUR: Duration = Duration::from_secs(3600);

examples/list_objects.rs

@@ -2,7 +2,7 @@ use std::error::Error as StdError;
 use std::time::Duration;
 
 use reqwest::Client;
-use rusty_s3::actions::{ListObjectsV2, S3Action};
+use rusty_s3::actions::{ListObjectsV2, S3Action as _};
 use rusty_s3::{Bucket, Credentials, UrlStyle};
 
 const ONE_HOUR: Duration = Duration::from_secs(3600);

examples/multipart_upload.rs

@@ -4,7 +4,9 @@ use std::time::Duration;
 
 use reqwest::header::ETAG;
 use reqwest::Client;
-use rusty_s3::actions::{CompleteMultipartUpload, CreateMultipartUpload, S3Action, UploadPart};
+use rusty_s3::actions::{
+    CompleteMultipartUpload, CreateMultipartUpload, S3Action as _, UploadPart,
+};
 use rusty_s3::{Bucket, Credentials, UrlStyle};
 
 const ONE_HOUR: Duration = Duration::from_secs(3600);

examples/sign_get.rs

@@ -1,6 +1,6 @@
 use std::time::Duration;
 
-use rusty_s3::actions::{GetObject, S3Action};
+use rusty_s3::actions::{GetObject, S3Action as _};
 use rusty_s3::{Bucket, Credentials, UrlStyle};
 
 const ONE_HOUR: Duration = Duration::from_secs(3600);

examples/sign_put.rs

@@ -1,6 +1,6 @@
 use std::time::Duration;
 
-use rusty_s3::actions::{PutObject, S3Action};
+use rusty_s3::actions::{PutObject, S3Action as _};
 use rusty_s3::{Bucket, Credentials, UrlStyle};
 
 const ONE_HOUR: Duration = Duration::from_secs(3600);

src/actions/delete_objects.rs

@@ -1,7 +1,7 @@
 use std::iter;
 use std::time::Duration;
 
-use md5::{Digest, Md5};
+use md5::{Digest as _, Md5};
 use serde::Serialize;
 use time::OffsetDateTime;
 use url::Url;
@@ -100,7 +100,7 @@
             .objects
             .map(|o| {
                 let mut nodes = vec![Node::Key(o.key.as_str())];
-                if let Some(ref version_id) = o.version_id {
+                if let Some(version_id) = &o.version_id {
                     nodes.push(Node::VersionId(version_id.as_str()));
                 }
                 Object { nodes }

src/base64.rs

@@ -1,5 +1,5 @@
 use ::base64::engine::general_purpose::STANDARD;
-use ::base64::engine::Engine;
+use ::base64::engine::Engine as _;
 
 pub fn encode<T: AsRef<[u8]>>(input: T) -> String {
     STANDARD.encode(input)

src/credentials/serde.rs

@@ -3,7 +3,7 @@ use std::mem;
 
 use serde::{Deserialize, Deserializer};
 use time::PrimitiveDateTime;
-use zeroize::Zeroize;
+use zeroize::Zeroize as _;
 
 use crate::time_::ISO8601_EXT;
 

src/signing/signature.rs

@@ -1,4 +1,4 @@
-use hmac::{Hmac, Mac};
+use hmac::{Hmac, Mac as _};
 use sha2::Sha256;
 use time::OffsetDateTime;
 use zeroize::Zeroizing;

src/signing/string_to_sign.rs

@@ -1,4 +1,4 @@
-use sha2::{Digest, Sha256};
+use sha2::{Digest as _, Sha256};
 use time::OffsetDateTime;
 
 use crate::time_::{ISO8601, YYYYMMDD};

tests/common.rs

@@ -1,7 +1,7 @@
 use std::time::Duration;
 
 use reqwest::Client;
-use rusty_s3::actions::{CreateBucket, S3Action};
+use rusty_s3::actions::{CreateBucket, S3Action as _};
 use rusty_s3::{Bucket, Credentials, UrlStyle};
 
 pub async fn bucket() -> (Bucket, Credentials, Client) {

tests/create_delete_bucket.rs

@@ -1,6 +1,6 @@
 use std::time::Duration;
 
-use rusty_s3::actions::S3Action;
+use rusty_s3::actions::S3Action as _;
 
 mod common;
 

tests/delete_objects.rs

@@ -3,7 +3,7 @@ use std::time::Duration;
 use reqwest::Client;
 use url::Url;
 
-use rusty_s3::actions::{ListObjectsV2, ListObjectsV2Response, ObjectIdentifier, S3Action};
+use rusty_s3::actions::{ListObjectsV2, ListObjectsV2Response, ObjectIdentifier, S3Action as _};
 
 mod common;
 

tests/list_parts.rs

@@ -1,7 +1,7 @@
 use reqwest::Client;
 use std::time::Duration;
 
-use rusty_s3::actions::{CreateMultipartUpload, ListParts, ListPartsResponse, S3Action};
+use rusty_s3::actions::{CreateMultipartUpload, ListParts, ListPartsResponse, S3Action as _};
 
 mod common;
 

tests/upload_download.rs

@@ -1,6 +1,6 @@
 use std::time::Duration;
 
-use rusty_s3::actions::{ListObjectsV2, S3Action};
+use rusty_s3::actions::{ListObjectsV2, S3Action as _};
 
 mod common;