Initial refactor: replace Scriptaculous dragdrop with SortableJS v1.15.6

papyri · Dec 10, 2024 · f7104c5 · f7104c5
1 parent e03dc97
commit f7104c5
Show file tree

Hide file tree

Showing 32 changed files with 3,431 additions and 1,019 deletions.
diff --git a/app/assets/javascripts/Sortable.js b/app/assets/javascripts/Sortable.js
diff --git a/app/assets/javascripts/apis.js b/app/assets/javascripts/apis.js
@@ -217,7 +217,7 @@ function multiUpdate(id, newItem)
   $$('#multiPlus_' + id + ' > input').each(function(item){item.clear();});
   $$('#multiPlus_' + id + ' > select').each(function(item){item.clear();});
 
-  Sortable.create('multiItems_' + id, {overlap: 'horizontal', constraint: false, handle: 'move'});
+  Sortable.create(document.getElementById('multiItems_' + id), {direction: 'horizontal', handle: '.move'});
 }
 
 function multiRemove(item)

diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
@@ -3,7 +3,7 @@
 //= require rails
 //= require rails-ujs
 //= require effects
-//= require dragdrop
+//= require Sortable
 //= require_self
 
 // Place your application-specific JavaScript functions and classes here

diff --git a/app/assets/javascripts/dclp.js b/app/assets/javascripts/dclp.js
@@ -252,7 +252,7 @@ function multiAddWork(e){
 '                            <span onclick="multiAddWorkAuthorAuthority(this)" title="✓">add</span>' +
 '                          </p>' +
 '                          <script>' +
-'                            Sortable.create(\'multiItems_workAuthorAuthority' + workIndex +'\', {overlap: \'horizontal\', constraint: false, handle: \'move\'});' +
+'                            Sortable.create(document.getElementById(\'multiItems_workAuthorAuthority' + workIndex +'\'), {direction: \'horizontal\', handle: \'.move\'});' +
 '                          </script>' +
 '                        </div>' +
 '                      </div>' +
@@ -274,7 +274,7 @@ function multiAddWork(e){
 '                            <span onclick="multiAddWorkTitleAuthority(this)" title="✓">add</span>' +
 '                          </p>' +
 '                          <script>' +
-'                            Sortable.create(\'multiItems_workTitleAuthority' + workIndex +'\', {overlap: \'horizontal\', constraint: false, handle: \'move\'});' +
+'                            Sortable.create(document.getElementById(\'multiItems_workTitleAuthority' + workIndex +'\'), {direction: \'horizontal\', handle: \'.move\'});' +
 '                          </script>' +
 '                        </div>' +
 '                        <input class="observechange workCertainty" id="hgv_meta_identifier_work_' + workIndex +'_children_title_children_certainty_value" name="hgv_meta_identifier[work][' + workIndex +'][children][title][children][certainty][value]" type="hidden">' +
@@ -297,7 +297,7 @@ function multiAddWork(e){
 '                            <span onclick="multiAddWorkExtraAnd(this)" title="✓">add and</span>' +
 '                          </p>' +
 '                          <script>' +
-'                            Sortable.create(\'multiItems_workExtra' + workIndex +'\', {overlap: \'horizontal\', constraint: false, handle: \'move\'});' +
+'                            Sortable.create(document.getElementById(\'multiItems_workExtra' + workIndex +'\'), {direction: \'horizontal\', handle: \'.move\'});' +
 '                          </script>' +
 '                        </div>' +
 '                        <div class="clear"></div>' +