Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create configmap if Fluentbit is enabled #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

Create configmap if Fluentbit is enabled #110

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edb7aab
feat(fluentbit): create configmap is Fluentbit is enabled
nlamirault Sep 3, 2024
6fd055c
fix(helm): documentation
nlamirault Sep 3, 2024
75e346b
feat(fluentbit): typo
nlamirault Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/ztka/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ dependencies:
condition: deploy.contour.enable
maintainers:
- name: Paralus Team
version: "0.2.9"
version: "0.2.10"
appVersion: "v0.2.8"
2 changes: 1 addition & 1 deletion charts/ztka/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

A Helm chart for Paralus ZTKA.

![Version: 0.2.9](https://img.shields.io/badge/Version-0.2.9-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.2.8](https://img.shields.io/badge/AppVersion-v0.2.8-informational?style=flat-square)
![Version: 0.2.10](https://img.shields.io/badge/Version-0.2.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.2.8](https://img.shields.io/badge/AppVersion-v0.2.8-informational?style=flat-square)

This chart bootstraps the Paralus deployment on a [Kubernetes](http://kubernetes.io) cluster using the [Helm](https://helm.sh) package manager.

Expand Down
2 changes: 2 additions & 0 deletions charts/ztka/templates/configmap-fluentbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.deploy.filebeat.enable }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlamirault filebeat is used to collect audit logs into the system via elasticsearch whereas Fluentbit is used to collect audit logs into the system via a database. Both cannot be used together, why are we trying to control fluentbit's configuration if filebeat is enabled ?

Can you elaborate on the problem and what are we trying to achieve here ?

Copy link
Contributor Author

@nlamirault nlamirault Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a typo. fixed.
If we set deploy.filebeat.enable: false, this configmap must not be deployed

apiVersion: v1
kind: ConfigMap
metadata:
Expand Down Expand Up @@ -92,3 +93,4 @@ data:
Password {{ include "ztka.dbPassword" . | }}
Database {{ include "ztka.dbName" . | }}
Table audit_logs
{{- end }}
Loading