Skip to content

Commit

Permalink
merge / rebase fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
michalkucharczyk committed Dec 4, 2024
1 parent 3b17a16 commit 4f767e5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ where
views.remove(&key);
//todo: merge heads up warning!
if views.is_empty() {
ctx.pending_dropped_transactions.push(*tx_hash);
self.pending_dropped_transactions.push(*tx_hash);
}
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,10 @@ where
let mempool_results = self.mempool.extend_unwatched(source, &xts);

if view_store.is_empty() {
return Ok(mempool_results.into_iter().map(|r| r.map(|r| r.hash)).collect::<Vec<_>>())
return Ok(mempool_results
.into_iter()
.map(|r| r.map(|r| r.hash).map_err(Into::into))
.collect::<Vec<_>>())
}

//todo: review + test maybe?
Expand Down Expand Up @@ -690,7 +693,9 @@ where
Ok(mempool_results
.into_iter()
.map(|result| {
result.and_then(|insertion| {
result
.map_err(Into::into)
.and_then(|insertion| {
submission_results
.next()
.expect("The number of Ok results in mempool is exactly the same as the size of to-views-submission result. qed.")
Expand Down

0 comments on commit 4f767e5

Please sign in to comment.