Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable purchasing credit #4459

Closed
wants to merge 3 commits into from

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

Closes #4454

@s0me0ne-unkn0wn s0me0ne-unkn0wn added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. labels May 14, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn requested a review from eskimor May 14, 2024 21:13
@s0me0ne-unkn0wn s0me0ne-unkn0wn requested a review from a team as a code owner May 14, 2024 21:13
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6202062

Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the approach here - I think we should disallow the calls using the BaseCallFilter in the runtimes, rather than commenting stuff out in the broker pallet.

This way could lead to version issues later - we will want to enable this at different times for each network, but potentially still want features/fixes that are added at later points. This could mean that we would need to maintain two versions of the pallet - one with purchase credit active, and one without.

@bkchr
Copy link
Member

bkchr commented May 15, 2024

I don't agree with the approach here - I think we should disallow the calls using the BaseCallFilter in the runtimes, rather than commenting stuff out in the broker pallet.

Yes, this 10000%. Also we should just get implement the credit system, as it is not that complicated.

@bkchr bkchr closed this May 15, 2024
@bkchr bkchr deleted the s0me0ne/disable-purchase-credit branch May 15, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable credits on coretimechain for now
4 participants