Improve pallet purchase file structure #6780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
approved these changes
Dec 7, 2024
|
/tip small |
|
@shawntabrizi A referendum for a small (20 DOT) tip was successfully submitted for @Krayt78 (14AgwoPjcRiEEJgjfHmvAqkjdERCG26WEvQUoGLuBzcXKMS2 on polkadot). Referendum number: 1338. |
shawntabrizi
added
the
R0-silent
gui1117
previously approved these changes
Dec 18, 2024
|
tests seem failing? |
…ub.com/Krayt78/polkadot-sdk into improve-pallet-purchase-file-structure
auto-merge was automatically disabled
December 18, 2024 09:19
Head branch was pushed to by a user without write access
my bad there were some unused imports, should be good now |
gui1117
approved these changes
Dec 19, 2024
Merged
via the queue into
paritytech:master
with commit Dec 19, 2024
03e5db1
201 of 203 checks passed
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
Linked to issue paritytech#590 I moved the mod, tests, mock and benchmarking to their own seperate file to reduce the bloat inside purchase.rs --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue #590
I moved the mod, tests, mock and benchmarking to their own seperate file to reduce the bloat inside purchase.rs