-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-revive] Fix caller_is_root
return value
#7086
base: master
Are you sure you want to change the base?
[pallet-revive] Fix caller_is_root
return value
#7086
Conversation
Co-authored-by: Cyrill Leutwiler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this seems to be more consistent with other similar API methods.
You'll need to add major
prdoc change (I think this constitutes a breaking change even though it only involves unstable methods).
Apparently there are no test fixtures for this.
/cmd prdoc --audience runtime_dev --bump major |
Sorry, only members of the organization paritytech members can run commands. |
@xermicus Can you trigger the command above? |
/cmd prdoc --audience runtime_dev --bump major |
Command "prdoc --audience runtime_dev --bump major" has failed ❌! See logs here |
@cmichi the bot can't push to your branch. Can you add it manually (there is also the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a minor for pallet-revive
(exporting a new type) and a major for pallet-revive-uapi
. Just copy and edit prdoc stuff from past PRs to this pallet.
Review required! Latest push from author must always be reviewed |
Closes #6767.
The return type of the host function
caller_is_root
was denoted asu32
inpallet_revive_uapi
. This PR fixes the return type tobool
.As a drive-by, the PR re-exports
pallet_revive::exec::Origin
to extend what can be tested externally.