Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCM v6 #7123

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

XCM v6 #7123

wants to merge 3 commits into from

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Jan 13, 2025

closes #7095

Setup XCM v6 but with a more extensible approach. This should be 100% ABI with XCM v5 currently but need tests to assert that.

This is only a (not so) quick draft and looking for initial feedbacks.

Ideally, in future XCM versions, we only need to implement the new instructions without the need to duplicate all the existing ones.

TODOs:

  • executor
  • builder
  • weight
  • upgrade
  • cleanup
  • tests

@xlc
Copy link
Contributor Author

xlc commented Jan 13, 2025

This is much more complicated than I initially anticipated. The struct Xcm is hardcoded everywhere so most of the new code are hardcoded to use Xcm v5. A big refactor is needed to fix those unwanted coupling.

@xlc
Copy link
Contributor Author

xlc commented Jan 13, 2025

most of the Xcm v5 code are written without any consideration of future compatibility, and now someone have to refactor all of it...

@acatangiu
Copy link
Contributor

approach looks good!

@xlc if you don't have the bandwidth to do this to completion (likely), I'm sure we can find someone in the ecosystem to do it, especially if you provide a good plan/framework/starting-point - let me know

@xlc
Copy link
Contributor Author

xlc commented Jan 13, 2025

@acatangiu that will be great. I will spend a few more days to do the core refactoring and then someone can help fix integrations with different runtimes and remaining tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor XCM code
2 participants