Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate AsyncBackingParams #7254

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

alindima
Copy link
Contributor

@alindima alindima commented Jan 20, 2025

Part of #5079.

Removes all usage of the static async backing params, replacing them with dynamically computed equivalent values (based on the claim queue and scheduling lookahead).

Adds a new runtime API for querying the scheduling lookahead value. If not present, falls back to 3 (the default value that is backwards compatible with values we have on production networks for allowed_ancestry_len)

Also resolves most of #4447, removing code that handles async backing not yet being enabled.
While doing this, I removed the support for collation protocol version 1 on collators, as it only worked for leaves not supporting async backing (which are none).
I also unhooked the legacy v1 statement-distribution (for the same reason as above). That subsystem is basically dead code now, so I had to remove some of its tests as they would no longer pass (since the subsystem no longer sends messages to the legacy variant). I did not remove the entire legacy subsystem yet, as that would pollute this PR too much. We can remove the entire v1 and v2 validation protocols in a follow up PR.

In another PR: remove test files with names prospective_parachains (it'd pollute this PR if we do now)

TODO:

  • add deprecation warnings
  • prdoc

- backing_implicit_view
- candidate-validation
- prospective-parachains
- provisioner
- collator protocol (both sides)
@alindima alindima added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Jan 20, 2025
@alindima alindima marked this pull request as draft January 20, 2025 10:21
@sandreim sandreim mentioned this pull request Jan 20, 2025
10 tasks
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12947326306
Failed job name: cargo-clippy

@alindima alindima marked this pull request as ready for review January 24, 2025 10:34
@alindima alindima changed the title WIP: deprecate AsyncBackingParams deprecate AsyncBackingParams Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant