fatxpool
: do not use individual transaction listeners
#7316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During 2s block investigation it turned out that ForkAwareTxPool::register_listeners call takes significant amount of time.
This PR implements the idea outlined in #7071. Instead of having a separate listener for every transaction in each view, we now use a single stream of aggregated events per view, with each stream providing events for all transactions in that view. Each event is represented as a tuple: (transaction-hash, transaction-status). This significantly reduce the time required for
maintain
.Review Notes
(transaction-hash, transaction-status)
,MultiViewListener
now has a task. This task is responsible for:controller_receiver
which provides side-channel commands (likeAddView
orFinalizeTransaction
) sent from the transaction pool.Todo
fatxpool
: improve event listeners #5495 🤔 ?Closes #7071