-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[collator-selection] Add delay to candidate deposit withdrawals #7317
Open
georgepisaltu
wants to merge
10
commits into
paritytech:master
Choose a base branch
from
georgepisaltu:collator-selection-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[collator-selection] Add delay to candidate deposit withdrawals #7317
georgepisaltu
wants to merge
10
commits into
paritytech:master
from
georgepisaltu:collator-selection-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
georgepisaltu
added
the
T2-pallets
This PR/Issue is related to a particular pallet.
label
Jan 23, 2025
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
/cmd prdoc --audience runtime_dev --bump minor |
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the collator selection pallet allows accounts to take the place of others in the candidate list by placing a higher bond than them. While the new candidate cannot lower their bond, they can leave the candidate set later and quickly rejoin with a lower deposit if nobody is watching to take their place by frontrunning the transaction. While this doesn't pose functional threats to the collator election system, it is undesirable behavior.
This PR solves this issue by introducing an unbonding period for candidates that leave the set voluntarily or that are kicked due to inactivity. In this case, the deposit is held until the unbonding period passes. Then, the funds can be released using the new
withdraw_unbonded
extrinsic call. Accounts that start unbonding cannot rejoin as candidates until the unbonding period has finished.