[pallet-revive] pack exceeding syscall arguments into registers

[xermicus]

This PR changes how we call runtime API methods with more than 6 arguments: They are no longer spilled to the stack but packed into registers instead. Pointers are 32 bit wide so we can pack two of them into a single 64 bit register. Since we mostly pass pointers, this technique effectively increases the number of arguments we can pass using the available registers.

To make this work for instantiate too we now pass the code hash and the call data in the same buffer, akin to how the create family opcodes work in the EVM. The code hash is fixed in size, implying the start of the constructor call data.

[xermicus]

bot fmt

[command-bot]

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8080673 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-d43e9094-e6fe-4e8f-822a-93bd1f6a5fe2 to cancel this command or bot cancel to cancel all commands in this pull request.

[github-actions]

We have migrated the command bot to GHA

Please, see the new usage instructions here or here. Soon the old commands will be disabled.

[command-bot]

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8080673 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8080673/artifacts/download.

[xermicus]

/cmd prdoc --audience runtime_dev --bump major

[xermicus]

/cmd bench --runtime dev --pallet pallet_revive

[github-actions]

Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here

[github-actions]

Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/pallets/collator-selection/src/weights.rs	leave_intent	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	new_session	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	register_as_candidate	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	set_invulnerables	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	take_candidate_slot	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmen	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmms	-	-	ERROR
substrate/frame/revive/src/weights.rs	seal_call_data_load	256.00ns	365.00ns	+42.58
substrate/frame/revive/src/weights.rs	seal_call_data_size	267.00ns	338.00ns	+26.59
substrate/frame/revive/src/weights.rs	seal_ref_time_left	273.00ns	344.00ns	+26.01
substrate/frame/revive/src/weights.rs	seal_origin	265.00ns	329.00ns	+24.15
substrate/frame/revive/src/weights.rs	seal_address	271.00ns	336.00ns	+23.99
substrate/frame/revive/src/weights.rs	seal_caller	305.00ns	378.00ns	+23.93
substrate/frame/revive/src/weights.rs	seal_to_account_id	29.00us	35.09us	+21.01
substrate/frame/revive/src/weights.rs	seal_gas_limit	280.00ns	331.00ns	+18.21
substrate/frame/revive/src/weights.rs	seal_base_fee	290.00ns	341.00ns	+17.59
substrate/frame/revive/src/weights.rs	seal_return_data_size	267.00ns	310.00ns	+16.10
substrate/frame/revive/src/weights.rs	seal_block_number	274.00ns	314.00ns	+14.60
substrate/frame/revive/src/weights.rs	seal_minimum_balance	279.00ns	315.00ns	+12.90
substrate/frame/revive/src/weights.rs	seal_value_transferred	274.00ns	309.00ns	+12.77
substrate/frame/revive/src/weights.rs	rollback_transient_storage	1.27us	1.41us	+11.04
substrate/frame/revive/src/weights.rs	seal_caller_is_root	299.00ns	332.00ns	+11.04
substrate/frame/revive/src/weights.rs	seal_now	290.00ns	316.00ns	+8.97
substrate/frame/revive/src/weights.rs	seal_own_code_hash	305.00ns	328.00ns	+7.54
substrate/frame/revive/src/weights.rs	seal_caller_is_origin	338.00ns	357.00ns	+5.62
substrate/frame/revive/src/weights.rs	seal_sr25519_verify	1.39ms	1.46ms	+5.29
substrate/frame/revive/src/weights.rs	seal_ecdsa_recover	48.07us	50.49us	+5.03

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_revive']

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12947462446
Failed job name: test-linux-stable