Bridges: emulated tests small nits/improvements #7322
Merged
+9
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…westend` from generic macro
…(bridges are opened with genesis setup)
bkontur
added
T6-XCM
|
/cmd prdoc --audience runtime_dev --bump patch |
bkontur
commented
Jan 24, 2025
bkontur
added
the
A4-needs-backport
raymondkfcheung
approved these changes
Jan 24, 2025
karolk91
approved these changes
Jan 24, 2025
franciscoaguirre
approved these changes
Jan 24, 2025
x3c41a
approved these changes
Jan 24, 2025
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7322-to-stable2407
git worktree add --checkout .worktree/backport-7322-to-stable2407 backport-7322-to-stable2407
cd .worktree/backport-7322-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 7710483541ce273df892c77a6e300aaa2efa1dca
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7322-to-stable2409
git worktree add --checkout .worktree/backport-7322-to-stable2409 backport-7322-to-stable2409
cd .worktree/backport-7322-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 7710483541ce273df892c77a6e300aaa2efa1dca
git push --force-with-lease |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
This PR includes minor fixes identified during work on the larger PR: [https://github.com/paritytech/polkadot-sdk/issues/6906](https://github.com/paritytech/polkadot-sdk/issues/6906). Specifically, this PR removes the use of `open_bridge_between_asset_hub_rococo_and_asset_hub_westend`, which is no longer relevant for BridgeHubs, as bridges are now created with genesis settings. This function was used in the generic `test_dry_run_transfer_across_pk_bridge` macro, which could cause compilation issues when used in other contexts (e.g. fellows repo). --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 7710483)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes minor fixes identified during work on the larger PR: #6906.
Specifically, this PR removes the use of
open_bridge_between_asset_hub_rococo_and_asset_hub_westend, which is no longer relevant for BridgeHubs, as bridges are now created with genesis settings. This function was used in the generictest_dry_run_transfer_across_pk_bridgemacro, which could cause compilation issues when used in other contexts (e.g. fellows repo).