-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-linux compilation warnings. #248
base: master
Are you sure you want to change the base?
Conversation
Hmmm... well, I'm not sure whether gating those to Linux is the way we want to go, due to a few reasons:
So I think what we could do:
|
Thanks for the suggestions! I've left a few |
.github/workflows/rust.yml
Outdated
- name: Install clippy (zygote toolchain) | ||
run: cd crates/polkavm-zygote && rustup component add clippy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zygote is (and will always be) Linux-only so for macOS it should be removed. (I guess you'll need to modify the clippy.sh
script to only run clippy on zygote on Linux; you can copy-paste the detection from run-all-tests.sh
)
I've started adding
#[cfg(target_os = "linux")]
but for some cases it starts a cascade of related code not being used, so I think it's safer to go with conditionally allowing dead code.Let me know what's your preference.