fix paraId filter for horizontal msgs

paritytech · Dec 11, 2023 · 5f26396 · 5f26396
1 parent 5945988
commit 5f26396
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/src/services/blocks/XCMDecoder.ts b/src/services/blocks/XCMDecoder.ts
@@ -92,12 +92,13 @@ export class XcmDecoder {
 				if (frame.pallet === 'parachainSystem' && frame.method === 'setValidationData') {
 					const data = extrinsic.args.data as ISanitizedParachainInherentData;
 					data.downwardMessages.forEach((msg) => {
-						const message = msg.data;
-						if (message.length > 0) {
+						const message = msg.msg;
+						if (message && message.toString().length > 0) {
 							const downwardMessage: IDownwardMessage[] = [];
 							const xcmMessageDecoded = this.decodeMsg(api, message);
 							downwardMessage.push({
 								sentAt: msg.sentAt,
+								msg: message.toString(),
 								data: xcmMessageDecoded,
 							});
 							xcmMessages.push({
@@ -109,14 +110,25 @@ export class XcmDecoder {
 						msgs.forEach((msg) => {
 							const horizontalMessage: IHorizontalMessage[] = [];
 							const xcmMessageDecoded = this.decodeMsg(api, msg.data.slice(1));
-							horizontalMessage.push({
-								sentAt: msg.sentAt,
-								paraId: index,
-								data: xcmMessageDecoded,
-							});
-							xcmMessages.push({
-								horizontalMessages: horizontalMessage,
-							});
+							if (paraId !== undefined && index.toString() === paraId) {
+								horizontalMessage.push({
+									sentAt: msg.sentAt,
+									paraId: index,
+									data: xcmMessageDecoded,
+								});
+								xcmMessages.push({
+									horizontalMessages: horizontalMessage,
+								});
+							} else if (paraId === undefined) {
+								horizontalMessage.push({
+									sentAt: msg.sentAt,
+									paraId: index,
+									data: xcmMessageDecoded,
+								});
+								xcmMessages.push({
+									horizontalMessages: horizontalMessage,
+								});
+							}
 						});
 					});
 				}

diff --git a/src/types/responses/BlockXCMMessages.ts b/src/types/responses/BlockXCMMessages.ts
@@ -21,6 +21,7 @@ export interface IUpwardMessage {
 
 export interface IDownwardMessage {
 	sentAt: string;
+	msg: string;
 	data: string;
 }