fix: per-call encoding count argument

parse-community · Mar 25, 2024 · f63a5a2 · f63a5a2
1 parent 9258b32
commit f63a5a2
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/src/encode.js b/src/encode.js
@@ -11,27 +11,26 @@ import { Op } from './ParseOp';
 import ParseRelation from './ParseRelation';
 
 const MAX_RECURSIVE_CALLS = 999;
-let recursiveCallsCount = 0;
 
 function encode(
   value: mixed,
   disallowObjects: boolean,
   forcePointers: boolean,
   seen: Array<mixed>,
-  offline: boolean
+  offline: boolean,
+  counter: number = 0
 ): any {
-  recursiveCallsCount++;
+  counter++;
 
-  if (recursiveCallsCount > MAX_RECURSIVE_CALLS) {
-    const errorMessage = 'Maximum recursive calls exceeded in encode function. Potential infinite recursion detected.';
-    console.warn(errorMessage);
-    console.debug('Value causing potential infinite recursion:', value);
-    console.debug('Disallow objects:', disallowObjects);
-    console.debug('Force pointers:', forcePointers);
-    console.debug('Seen:', seen);
-    console.debug('Offline:', offline);
+  if (counter > MAX_RECURSIVE_CALLS) {
+    console.error('Maximum recursive calls exceeded in encode function. Potential infinite recursion detected.');
+    console.error('Value causing potential infinite recursion:', value);
+    console.error('Disallow objects:', disallowObjects);
+    console.error('Force pointers:', forcePointers);
+    console.error('Seen:', seen);
+    console.error('Offline:', offline);
 
-    throw new Error(errorMessage);
+    throw new Error('Maximum recursive calls exceeded in encode function. Potential infinite recursion detected.');
   }
 
   if (value instanceof ParseObject) {
@@ -84,14 +83,14 @@ function encode(
 
   if (Array.isArray(value)) {
     return value.map(v => {
-      return encode(v, disallowObjects, forcePointers, seen, offline);
+      return encode(v, disallowObjects, forcePointers, seen, offline, counter);
     });
   }
 
   if (value && typeof value === 'object') {
     const output = {};
     for (const k in value) {
-      output[k] = encode(value[k], disallowObjects, forcePointers, seen, offline);
+      output[k] = encode(value[k], disallowObjects, forcePointers, seen, offline, counter);
     }
     return output;
   }
@@ -106,6 +105,5 @@ export default function (
   seen?: Array<mixed>,
   offline?: boolean
 ): any {
-  recursiveCallsCount = 0;
-  return encode(value, !!disallowObjects, !!forcePointers, seen || [], offline);
+  return encode(value, !!disallowObjects, !!forcePointers, seen || [], offline, 0);
 }