Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chrome browser console warning about unsafe header access-control-expose-headers when calling Cloud Function #2095

Merged
merged 10 commits into from
Apr 22, 2024
Merged

fix: Chrome browser console warning about unsafe header access-control-expose-headers when calling Cloud Function #2095

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0f5f317
check if header is available before calling `xhr.getResponseHeader` t…
mortenmo Mar 17, 2024
ac39725
Merge branch 'alpha' into fix-chrome-console-error
mtrezza Mar 17, 2024
7360318
avoid requiring `getAllResponseHeaders` on xhr. Clean tests from requ…
mortenmo Apr 13, 2024
4e01e58
Merge branch 'alpha' into fix-chrome-console-error
mtrezza Apr 15, 2024
535e2f7
Update RESTController.js
mtrezza Apr 15, 2024
b27155b
Test for Chrome issue
mortenmo Apr 18, 2024
b777ded
Update src/__tests__/RESTController-test.js
mtrezza Apr 18, 2024
50f087d
Update src/__tests__/RESTController-test.js
mtrezza Apr 18, 2024
43dc7b9
Update src/__tests__/RESTController-test.js
mtrezza Apr 18, 2024
ac3e1dd
Lint issues
mortenmo Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/RESTController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,14 @@ const RESTController = {
let response;
try {
response = JSON.parse(xhr.responseText);
const availableHeaders = typeof xhr.getAllResponseHeaders === 'function' ? xhr.getAllResponseHeaders() : "";
headers = {};
if (typeof xhr.getResponseHeader === 'function' && xhr.getResponseHeader('access-control-expose-headers')) {
if (typeof xhr.getResponseHeader === 'function' && availableHeaders?.indexOf('access-control-expose-headers') >= 0) {
const responseHeaders = xhr.getResponseHeader('access-control-expose-headers').split(', ');
responseHeaders.forEach(header => {
headers[header] = xhr.getResponseHeader(header.toLowerCase());
if (availableHeaders.indexOf(header.toLowerCase()) >= 0) {
headers[header] = xhr.getResponseHeader(header.toLowerCase());
}
});
}
} catch (e) {
Expand Down
63 changes: 63 additions & 0 deletions src/__tests__/RESTController-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ describe('RESTController', () => {
getResponseHeader: function (header) {
return headers[header];
},
getAllResponseHeaders: function() {
return Object.keys(headers).map(key => `${key}: ${headers[key]}`).join('\n');
},
send: function () {
this.status = 200;
this.responseText = '{}';
Expand All @@ -241,6 +244,9 @@ describe('RESTController', () => {
getResponseHeader: function (header) {
return headers[header];
},
getAllResponseHeaders: function() {
return Object.keys(headers).map(key => `${key}: ${headers[key]}`).join('\n');
},
send: function () {
this.status = 200;
this.responseText = '{}';
Expand All @@ -253,6 +259,63 @@ describe('RESTController', () => {
expect(response._headers['X-Parse-Push-Status-Id']).toBe('5678');
});

it('does not call getRequestHeader with no headers or no getAllResponseHeaders', async () => {
const XHR = function () {};
XHR.prototype = {
open: function () {},
setRequestHeader: function () {},
getResponseHeader: jest.fn(),
send: function () {
this.status = 200;
this.responseText = '{"result":"hello"}';
this.readyState = 4;
this.onreadystatechange();
},
};
RESTController._setXHR(XHR);
await RESTController.request('GET', 'classes/MyObject', {}, {});
expect(XHR.prototype.getResponseHeader.mock.calls.length).toBe(0);

XHR.prototype.getAllResponseHeaders = jest.fn();
await RESTController.request('GET', 'classes/MyObject', {}, {});
expect(XHR.prototype.getAllResponseHeaders.mock.calls.length).toBe(1);
expect(XHR.prototype.getResponseHeader.mock.calls.length).toBe(0);
});

it('mimics Chrome browser console error on getResponseHeader', async () => {
mtrezza marked this conversation as resolved.
Show resolved Hide resolved
const headers = {
'access-control-expose-headers': 'a, b, c',
'a' : 'value',
'b' : 'value',
'c' : 'value',
}
const XHR = function () {};
XHR.prototype = {
open: function () {},
setRequestHeader: function () {},
getResponseHeader: jest.fn(key => {
if (Object.keys(headers).includes(key)) {
return headers[key];
}
throw new Error("Chrome creates a console error here.");
}),
getAllResponseHeaders: jest.fn(() => {
return Object.keys(headers).map(key => `${key}: ${headers[key]}`).join('\r\n');
}),
send: function () {
this.status = 200;
this.responseText = '{"result":"hello"}';
this.readyState = 4;
this.onreadystatechange();
},
};
RESTController._setXHR(XHR);
await RESTController.request('GET', 'classes/MyObject', {}, {});
expect(XHR.prototype.getAllResponseHeaders.mock.calls.length).toBe(1);
expect(XHR.prototype.getResponseHeader.mock.calls.length).toBe(4);
});


it('handles invalid header', async () => {
const XHR = function () {};
XHR.prototype = {
Expand Down
Loading