Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Internal server error on set followed by unset #2298

Closed
wants to merge 1 commit into from
Closed

fix: Internal server error on set followed by unset #2298

wants to merge 1 commit into from

Conversation

harshbhar0629
Copy link

Pull Request

Issue

Closes: #1798

Approach

In main.js I found 2 mistake

before

Now:

after

Because it returns promise and this is best practice to use async await to handle promise o/w use .then and catch.

Tasks

Handle internal server error.

Copy link

Thanks for opening this pull request!

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to add new tests, instead of modifying existing tests. Modifications of existing tests should not be necessary unless it's a breaking change, which we want to avoid.

If you find any unrelated issues with tests, they should be fixed in a separate PR. However, it would be surprising if there were any issues with these tests, because why would the tests currently pass.

@mtrezza mtrezza changed the title Fixes internal server error fix: Internal server error on set followed by unset Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (b043c0a).
Report is 165 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2298    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6356   +170     
  Branches      1499      1526    +27     
==========================================
+ Hits          6186      6356   +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshbhar0629 harshbhar0629 closed this by deleting the head repository Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal server error on set followed by unset
2 participants