refactor: Improve incorrect deprecation log message for auth adapter (#…

…8347)
parse-community · Dec 6, 2022 · b48c270 · b48c270
1 parent 536bb2f
commit b48c270
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/spec/AuthenticationAdapters.spec.js b/spec/AuthenticationAdapters.spec.js
@@ -590,16 +590,17 @@ describe('AuthenticationProviders', function () {
     );
   });
 
-  it('can depreciate', async () => {
+  it('can deprecate', async () => {
     await reconfigureServer();
     const Deprecator = require('../lib/Deprecator/Deprecator');
     const spy = spyOn(Deprecator, 'logRuntimeDeprecation').and.callFake(() => {});
     const provider = getMockMyOauthProvider();
     Parse.User._registerAuthenticationProvider(provider);
     await Parse.User._logInWith('myoauth');
     expect(spy).toHaveBeenCalledWith({
-      usage: 'auth.myoauth',
-      solution: 'auth.myoauth.enabled: true',
+      usage: 'Using the authentication adapter "myoauth" without explicitly enabling it',
+      solution:
+        'Enable the authentication adapter by setting the Parse Server option "auth.myoauth.enabled: true".',
     });
   });
 });

diff --git a/src/Auth.js b/src/Auth.js
@@ -435,8 +435,8 @@ const handleAuthDataValidation = async (authData, req, foundUser) => {
       const authProvider = (req.config.auth || {})[provider] || {};
       if (authProvider.enabled == null) {
         Deprecator.logRuntimeDeprecation({
-          usage: `auth.${provider}`,
-          solution: `auth.${provider}.enabled: true`,
+          usage: `Using the authentication adapter "${provider}" without explicitly enabling it`,
+          solution: `Enable the authentication adapter by setting the Parse Server option "auth.${provider}.enabled: true".`,
         });
       }
       if (!validator || authProvider.enabled === false) {