-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New menu mechanism and style fixes #1
base: master
Are you sure you want to change the base?
Conversation
This fixes for example the media manager. This leads to some style differences here and there, but they should be fixed in design.css instead.
This overrides some styles by the KIT design to assign margins consistently
It is not clear to me why this is not in the KIT css as other KIT webpages have this rule.
Other KIT pages use two different CSS files for this
This makes it possible to use the wrap plugin to create columns with grid styles that scale nicely for mobile devices.
The index-based approach is currently unsupported. This fully implements support for the mobile menu and translated menus. This also makes the trace completely independent from the namespace structure allowing very flexible menu structures.
There is no reason to not to include it for anonymous users apart from slightly higher server load.
This changes the German text from "Suchen" to "Suche", but I think this is okay.
This happens with pages in the root namespace that are not part of the menu.
The images are changed every five seconds.
Hi @michitux (sorry for the late reaction, somehow missed the notification)! Thanks for sharing your work! I think a lot of this can be quite useful to improve user and admin experience. I think by now both(?) of us have dropped out of KIT. I tend to still support these kind of projects but don't want to make breaking-changes that potentially cause more temporary work for the institute admins. I'll let it up to you to refactor the PR with the old file- and dynamic menu as additional options or to the new admins (@particleadmin) to do whatever they think is appropriate. |
This is a PR that includes everything that I have changed while adapting the template for https://i11www.iti.kit.edu/
Please let me know if you want to merge this as is (which means you need to at least adapt your menu), if you want to cherry-pick the changes/commits you want or if I shall create a separate pull request with only a subset of the changes.
Apart from several small style fixes this includes a completely different way to specify the navigation menu that completely replaces the old mechanism. It is adapted from the navi plugin and uses a simple DokuWiki list to specify the menu. As part of that I have implemented all features that I noticed in the official menu, in particular better mobile support. The trace with its drop down menus is now also completely based on this navigation menu. It won't display pages that are not included in the navigation menu but will instead display the start page or the first included page of its namespace or a parent namespace. I did not have the motivation to adapt the sitemap-based menu to the new features, therefore I disabled it.
Other more noteworthy changes:
column
andfourth
configured to get no prefix to display columns in the footer as shown in official examples. These columns then also respond to changes in the display width.