Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter - get variable descriptions from Figma #13

Closed
srambach opened this issue Jan 24, 2024 · 0 comments · Fixed by #64
Closed

Exporter - get variable descriptions from Figma #13

srambach opened this issue Jan 24, 2024 · 0 comments · Fixed by #64
Assignees

Comments

@srambach
Copy link
Member

srambach commented Jan 24, 2024

Figma allows for entry of a description for each variable (token). We need to pull these into the token file so that the docs framework can consume them for display.

(And Figma will need to have the descriptions added)

Information from @mfrances17:

  • The README will explain how to get the plugin installed and working in the Figma library.
  • The code to focus on is in code.js, and is written in vanilla javascript but should be rewritten as Typescript
  • To debug, import the manifest from a cloned design-tokens repo as instructed in the readme and the changes you make in code.js should be reflected in real time as the plugin is running.
  • What i’ve tried and should work is to use figma.variables.getVariableById(value.id).description to pull in the descriptions, but every figma library i’ve tried it on, description is coming back empty or undefined.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 24, 2024
@srambach srambach changed the title Import Figma variable descriptions Export variable descriptions from Figma Feb 20, 2024
@srambach srambach changed the title Export variable descriptions from Figma Exporter - get variable descriptions from Figma Feb 20, 2024
@srambach srambach moved this from Needs triage to Ready to assign in PatternFly Issues Mar 20, 2024
@srambach srambach added this to the Penta alpha omega release milestone Apr 4, 2024
@srambach srambach added the PF6 label Apr 5, 2024
@srambach srambach linked a pull request Jun 5, 2024 that will close this issue
@srambach srambach self-assigned this Jun 5, 2024
@srambach srambach moved this from Ready to assign to PR Review in PatternFly Issues Jun 5, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants