Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter): export description to json files #64

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

srambach
Copy link
Member

@srambach srambach commented Jun 5, 2024

This adds description to the items exported for each variable. Right now you can see some on the semantic tokens.

The docs code still needs to be updated to include it when building the documentation.

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!! I just opened a design kit issue to add more variable descriptions patternfly/patternfly-design-kit#746

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆 you are now a JS dev!

@nicolethoen nicolethoen merged commit 20fee76 into patternfly:main Jun 7, 2024
3 checks passed
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter - get variable descriptions from Figma
4 participants