fix: fixed accessibility for pf-table

patternfly · Dec 10, 2024 · 7f189ae · 7f189ae
1 parent 5940f37
commit 7f189ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/elements/pf-table/pf-th.ts b/elements/pf-table/pf-th.ts
@@ -51,7 +51,7 @@ export class PfTh extends LitElement {
     const closestThead = this.closest('pf-thead');
     const closestTable = this.closest('pf-table');
     const isChildOfThead = !!closestThead && !!closestTable?.contains(closestThead);
-    const role = isChildOfThead ? 'colheader' : 'rowheader';
+    const role = isChildOfThead ? 'columnheader' : 'rowheader';
     this.setAttribute('role', role);
   }
 

diff --git a/elements/pf-table/pf-tr.ts b/elements/pf-table/pf-tr.ts
@@ -110,6 +110,7 @@ export class PfTr extends LitElement {
           <pf-button id="toggle-button"
                      aria-expanded=${String(this.expanded) as 'true' | 'false'}
                      plain
+                     label="Expand Button"
                      @click=${this.#onClick}>
             <pf-icon id="toggle-icon"
                      icon="angle-right"