feat(back-to-top): pf-back-to-top element #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16a5dba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
demo
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nikkimk
previously requested changes
Oct 27, 2023
bennypowers
requested changes
Oct 31, 2023
bennypowers
approved these changes
Dec 5, 2023
bennypowers
dismissed
nikkimk’s stale review
on the assumption that Nikki's earlier notes were addressed by Steven's patches, merging now to enable us to release 2.5.0 on time.
|
Merging ahead of 2.5.0. @nikkimk @hellogreg please open new issues for anything that comes up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
<pf-back-to-top>elementTodo
Determine accessibility improvementsA href attribute and using a<a>in shadowdom is warranted as expected. Can still use button version but there is caveat of owning accessibility in implementation, such as setting focus on element scrolled to.Figure out improvements for how a user hooks up element to "returning to top". PFv4 doesn't make assumptions on how the button is hooked up. We may opt for aSee above,hrefattribute and use a link instead of a button when present, and definitely have to add a event when button is clicked otherwise for implementors to hook into.hrefimplementationTesting Instructions
Notes to Reviewers