Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): remove animation #2598

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

bennypowers
Copy link
Member

fixes #2597

What I did

  1. remove animations from accordion

Notes to Reviewers

  1. although this change removes things, i believe all the removed elements are private, so this is a patch. Please confirm

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 557c64e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers enabled auto-merge (squash) September 27, 2023 10:06
@github-actions github-actions bot added doc functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass labels Sep 27, 2023
@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 50a03da
😎 Deploy Preview https://deploy-preview-2598--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Sep 27, 2023
@bennypowers bennypowers requested review from brianferry and nikkimk and removed request for brianferry October 8, 2023 04:58
Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literary Goals Terms Marble

@bennypowers bennypowers merged commit 1bdc31a into main Oct 18, 2023
@bennypowers bennypowers deleted the fix/accordion/no-animate-expand branch October 18, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed doc functionality Functionality, typically pertaining to the JavaScript. ready to merge styles An issue or PR pertaining only to CSS/Sass
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] Accordion should not animate
2 participants