Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text-area): add pf-text-area #2639

Merged
merged 11 commits into from
Dec 6, 2023
Merged

feat(text-area): add pf-text-area #2639

merged 11 commits into from
Dec 6, 2023

Conversation

bennypowers
Copy link
Member

What I did

  1. add features to InternalsController
  2. move code from PfTextInput to InternalsController
  3. add pf-text-area

Testing Instructions

  1. extensive usability testing is required
  2. re-test pf-text-area which is also updated here

Notes to Reviewers

  1. depending on which PR is merged first, this also could impact pf-checkbox, radio, switch - anything with element internals
  2. i'm not 100% clear on the polyfill story, so try in webkit and firefox as well

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d135c52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/pfe-core Minor
@patternfly/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing labels Oct 20, 2023
@bennypowers bennypowers marked this pull request as draft October 20, 2023 08:09
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 858083f
😎 Deploy Preview https://deploy-preview-2639--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Oct 20, 2023
@bennypowers
fix(text-area): styles
e08bb65 
still to do: validations, icons, auto-resize
@github-actions github-actions bot added the work in progress POC / Not ready for review label Oct 20, 2023
@bennypowers
fix(text-area): styles and states
3632605 
still to do: success and warning states, autoresize
@bennypowers
fix: allow for build
c13156a
@bennypowers bennypowers marked this pull request as ready for review November 1, 2023 19:56
@bennypowers bennypowers added this to the PatternFly Elements 3 milestone Nov 8, 2023
@bennypowers bennypowers linked an issue Dec 4, 2023 that may be closed by this pull request
[1:1]: pf-text-area #2568
Closed
@bennypowers
Copy link
Member Author

@nikkimk and @hellogreg hoping for some end-of-calendar year ux testing on this one, as much the two of you are available before the break. TYVM

@bennypowers bennypowers requested a review from zeroedin December 5, 2023 08:07
zeroedin
zeroedin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linguistic genius: text mastery

@bennypowers
Copy link
Member Author

merging prior to UX testing. @hellogreg, @nikkimk please open new issues for anything you catch. Hopefully we can sort those before 2.5.0, otherwise we'll issue patches.

@bennypowers bennypowers merged commit c71bbe5 into main Dec 6, 2023
16 checks passed
@bennypowers bennypowers deleted the feat/pf-text-area branch December 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroedin zeroedin zeroedin approved these changes

@brianferry brianferry Awaiting requested review from brianferry

Assignees
No one assigned
Labels
AT passed Automated testing has passed demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing work in progress POC / Not ready for review
Projects
Workflow
Status: Done
Milestone
PatternFly Elements 3
Development

Successfully merging this pull request may close these issues.

[1:1]: pf-text-area
2 participants
@bennypowers @zeroedin