Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): react wrapper syntax errors #2772

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

bennypowers
Copy link
Member

What I did

  1. remove extraneous , from generated react wrapper modules when there is more than one element exported.

Testing Instructions

  1. run the build on rhds and confirm that rh-navigation-secondary-dropdown.js does not include the pattern /;,$/

Notes to Reviewers

  1. See Package Issue - @rhds/[email protected] jspm/project#336 (comment)
  2. With many thanks to the inimitable @guybedford

Copy link

changeset-bot bot commented Jun 16, 2024

🦋 Changeset detected

Latest commit: 8eb61f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the tools Development and build tools label Jun 16, 2024
@github-actions github-actions bot added the AT passed Automated testing has passed label Jun 16, 2024
@bennypowers bennypowers merged commit 9995136 into main Jun 16, 2024
9 of 16 checks passed
@bennypowers bennypowers deleted the fix/tools/react-wrappers/multiple-imports branch June 16, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed tools Development and build tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant