Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): slotController isEmpty respects text nodes #2880

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Nov 20, 2024

What I did

  1. make slotcontroller's hasContent/isEmpty consider text nodes

Testing Instructions

  1. patch contents into RHDS, and check that cards with text nodes in default slot but no wrapping element still display their contents

Notes to Reviewers

  1. see https://stackblitz.com/edit/stackblitz-starters-u2qbnw?file=index.html

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: e5103c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 20, 2024

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(core): slotController isEmpty respects text nodes"
}

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit f220b8f
😎 Deploy Preview https://deploy-preview-2880--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Nov 20, 2024
Copy link
Contributor

SSR Test Run for f220b8f: Report

@adamjohnson adamjohnson self-requested a review December 2, 2024 19:30
Copy link
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letters get thoroughly matched 👍

@bennypowers bennypowers merged commit 0fb28b6 into main Dec 3, 2024
18 of 19 checks passed
@bennypowers bennypowers deleted the fix/core/is-empty-slot-text branch December 3, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants