Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ssr events #2891

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(core): ssr events #2891

wants to merge 10 commits into from

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Jan 13, 2025

What I did

  1. update lit packages related to ssr and context (i.e. events in ssr)

Testing Instructions

  1. view SSR test output, there should be no errors related to addEventListener

Notes to Reviewers

  1. see [docs] Add documentation for SSR event handling lit/lit.dev#1390 and [labs/ssr] Implement SSR custom elements event handling lit/lit#4755
  2. there are some element refactors here which account for the fact that we're opting in to calling connectedCallback and hostConnected - i suspect some of these should be refactored in order to make that more clear from the code
  3. netlify builds are failing, probably because there are too many files. that will have to be dealt with somehow

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 9bd0874

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/pfe-core Patch
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers changed the title Fix/ssr events fix(core): ssr events Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(core): ssr events"
}

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit ed2a4c9
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/6784fd3151aaf00008049196
😎 Deploy Preview https://deploy-preview-2891--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 13, 2025
Copy link
Contributor

SSR Test Run for 2877a4b: Report

Copy link
Contributor

SSR Test Run for 5c9ba1c: Report

Copy link
Contributor

SSR Test Run for 09809cd: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant